Changeset 49856

Timestamp:

12/21/2020 05:09:50 PM (4 years ago)

Author:

johnbillion

Message:

XML-RPC: Fix a type error when requesting the menu field of a taxonomy.

Fixes #51493

Location:

trunk

Files:

• src/wp-includes/class-wp-xmlrpc-server.php (modified) (1 diff)
• tests/phpunit/tests/xmlrpc/wp/getTaxonomy.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -767 +767 @@
 
         if ( in_array( 'menu', $fields, true ) ) {
-            $_taxonomy['show_in_menu'] = (bool) $_taxonomy->show_in_menu;
+            $_taxonomy['show_in_menu'] = (bool) $taxonomy->show_in_menu;
         }
 

trunk/tests/phpunit/tests/xmlrpc/wp/getTaxonomy.php

@@ -61 +61 @@
         $this->assertSame( (array) $taxonomy->object_type, $result['object_type'], 'object_types' );
     }
+
+    /**
+     * @ticket 51493
+     */
+    function test_taxonomy_with_menu_field_specified() {
+        $this->make_user_by_role( 'editor' );
+
+        $fields = array(
+            'menu',
+        );
+
+        $result = $this->myxmlrpcserver->wp_getTaxonomy( array( 1, 'editor', 'editor', 'category', $fields ) );
+        $this->assertNotIXRError( $result );
+        $this->assertTrue( $result['show_in_menu'] );
+    }
 }