Changeset 49863

Timestamp:

12/22/2020 07:42:23 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use shared post fixture in comment template tests.

This reinstates [49848], previously reverted in [49849], with the addition of static keyword for the wpSetUpBeforeClass() method, allowing the tests to pass on PHP 8.

Props peterwilsoncc.
See #51802.

File:

• trunk/tests/phpunit/tests/comment/template.php (modified) (5 diffs)

trunk/tests/phpunit/tests/comment/template.php

@@ -4 +4 @@
  */
 class Tests_Comment_Template extends WP_UnitTestCase {
+    /**
+     * Shared post ID.
+     *
+     * @var int
+     */
+    public static $post_id;
+
+    /**
+     * Set up shared fixtures.
+     *
+     * @param WP_UnitTest_Factory $factory Unit test factory.
+     */
+    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+        self::$post_id = self::factory()->post->create();
+    }
 
     function test_get_comments_number() {
-        $post_id = self::factory()->post->create();
+        $post_id = self::$post_id;
 
         $this->assertSame( 0, get_comments_number( 0 ) );
@@ -19 +34 @@
 
     function test_get_comments_number_without_arg() {
-        $post_id   = self::factory()->post->create();
+        $post_id   = self::$post_id;
         $permalink = get_permalink( $post_id );
         $this->go_to( $permalink );
@@ -35 +50 @@
      */
     function test_get_comments_number_text_with_post_id() {
-        $post_id = $this->factory->post->create();
+        $post_id = self::$post_id;
         $this->factory->comment->create_post_comments( $post_id, 6 );
 
@@ -54 +69 @@
      */
     function test_get_comments_number_text_declension_with_default_args() {
-        $post_id   = $this->factory->post->create();
+        $post_id   = self::$post_id;
         $permalink = get_permalink( $post_id );
         $this->go_to( $permalink );
@@ -77 +92 @@
      */
     function test_get_comments_number_text_declension_with_custom_args( $number, $input, $output ) {
-        $post_id   = $this->factory->post->create();
+        $post_id   = self::$post_id;
         $permalink = get_permalink( $post_id );