Changeset 4990 for trunk/wp-admin/upgrade-functions.php

Timestamp:

03/07/2007 05:29:15 AM (19 years ago)

Author:

markjaquith

Message:

Use strpos instead of strstr where ever possible, for speed. Props rob1n. fixes #3920

File:

• trunk/wp-admin/upgrade-functions.php (modified) (2 diffs)

trunk/wp-admin/upgrade-functions.php

@@ -923 +923 @@
                 if ($oldfile == 'index.php') { // Check to make sure it's not a new index
                         $index = implode('', file("$oldpath/$oldfile"));
-                        if ( strstr( $index, 'WP_USE_THEMES' ) ) {
+                        if (strpos($index, 'WP_USE_THEMES') !== false) {
                                 if (! @copy(ABSPATH . 'wp-content/themes/default/index.php', "$site_dir/$newfile"))
                                         return false;
@@ -995 +995 @@
 
                 foreach ($stylelines as $line) {
-                        if (strstr($line, "Theme Name:")) $line = "Theme Name: $theme_name";
-                        elseif (strstr($line, "Theme URI:")) $line = "Theme URI: " . __get_option('siteurl');
-                        elseif (strstr($line, "Description:")) $line = "Description: Your theme";
-                        elseif (strstr($line, "Version:")) $line = "Version: 1";
-                        elseif (strstr($line, "Author:")) $line = "Author: You";
-                        fwrite($f, "{$line}\n");
+                        if (strpos($line, 'Theme Name:') !== false) $line = 'Theme Name: ' . $theme_name;
+                        elseif (strpos($line, 'Theme URI:') !== false) $line = 'Theme URI: ' . __get_option('url');
+                        elseif (strpos($line, 'Description:') !== false) $line = 'Description: Your theme.';
+                        elseif (strpos($line, 'Version:') !== false) $line = 'Version: 1';
+                        elseif (strpos($line, 'Author:') !== false) $line = 'Author: You';
+                        fwrite($f, $line . "\n");
                 }
                 fclose($f);