Changeset 49916 for trunk/tests/phpunit/includes/abstract-testcase.php

Timestamp:

01/02/2021 12:19:41 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Check if Travis/GitHub Actions environment variables are defined.

This adjusts the logic for determining whether to skip some tests when not in the primary branch, and allows for running these tests locally.

Follow-up to [47000], [47001], [49264], [49267], [49280].

See #50401.

File:

• trunk/tests/phpunit/includes/abstract-testcase.php (modified) (3 diffs)

trunk/tests/phpunit/includes/abstract-testcase.php

@@ -182 +182 @@
      * Allow tests to be skipped on some automated runs.
      *
-     * For test runs on Travis/GitHub Actions for something other than trunk/master, we want to skip tests that
-     * only need to run for master.
+     * For test runs on Travis/GitHub Actions for something other than trunk/master,
+     * we want to skip tests that only need to run for master.
      */
     public function skipOnAutomatedBranches() {
@@ -194 +194 @@
         $github_ref        = getenv( 'GITHUB_REF' );
 
-        if ( 'false' !== $github_event_name ) {
+        if ( $github_event_name && 'false' !== $github_event_name ) {
             // We're on GitHub Actions.
             $skipped = array( 'pull_request', 'pull_request_target' );
@@ -201 +201 @@
                 $this->markTestSkipped( 'For automated test runs, this test is only run on trunk/master' );
             }
-        } elseif ( 'false' !== $travis_branch ) {
+        } elseif ( $travis_branch && 'false' !== $travis_branch ) {
             // We're on Travis CI.
             if ( 'master' !== $travis_branch || 'false' !== $travis_pull_request ) {