Changeset 49932 for trunk/tests/phpunit/tests/user/author.php

Timestamp:

01/04/2021 11:32:49 PM (4 years ago)

Author:

peterwilsoncc

Message:

Tests: Increase use of shared fixtures in capability checks.

See #51802.

File:

• trunk/tests/phpunit/tests/user/author.php (modified) (7 diffs)

trunk/tests/phpunit/tests/user/author.php

@@ -16 +16 @@
         self::$author_id = $factory->user->create(
             array(
-                'role'        => 'author',
-                'user_login'  => 'test_author',
-                'description' => 'test_author',
+                'role'         => 'author',
+                'user_login'   => 'test_author',
+                'display_name' => 'Test Author',
+                'description'  => 'test_author',
             )
         );
@@ -49 +50 @@
 
         $this->assertSame( $user->display_name, $author_name );
-        $this->assertSame( 'test_author', $author_name );
+        $this->assertSame( 'Test Author', $author_name );
     }
 
@@ -55 +56 @@
         $this->assertSame( 'test_author', get_the_author_meta( 'login' ) );
         $this->assertSame( 'test_author', get_the_author_meta( 'user_login' ) );
-        $this->assertSame( 'test_author', get_the_author_meta( 'display_name' ) );
+        $this->assertSame( 'Test Author', get_the_author_meta( 'display_name' ) );
 
         $this->assertSame( 'test_author', trim( get_the_author_meta( 'description' ) ) );
@@ -111 +112 @@
      */
     public function test_get_the_author_posts_link_no_permalinks() {
-        $author = self::factory()->user->create_and_get(
-            array(
-                'display_name'  => 'Foo',
-                'user_nicename' => 'bar',
-            )
-        );
+        $author = get_userdata( self::$author_id );
 
         $GLOBALS['authordata'] = $author->data;
@@ -125 +121 @@
 
         $this->assertContains( $url, $link );
-        $this->assertContains( 'Posts by Foo', $link );
-        $this->assertContains( '>Foo</a>', $link );
+        $this->assertContains( 'Posts by Test Author', $link );
+        $this->assertContains( '>Test Author</a>', $link );
 
         unset( $GLOBALS['authordata'] );
@@ -137 +133 @@
         $this->set_permalink_structure( '/%postname%/' );
 
-        $author = self::factory()->user->create_and_get(
-            array(
-                'display_name'  => 'Foo',
-                'user_nicename' => 'bar',
-            )
-        );
+        $author = get_userdata( self::$author_id );
 
         $GLOBALS['authordata'] = $author;
@@ -153 +144 @@
 
         $this->assertContains( $url, $link );
-        $this->assertContains( 'Posts by Foo', $link );
-        $this->assertContains( '>Foo</a>', $link );
+        $this->assertContains( 'Posts by Test Author', $link );
+        $this->assertContains( '>Test Author</a>', $link );
 
         unset( $GLOBALS['authordata'] );