Changeset 49944 for trunk/src/wp-admin/network/site-users.php

Timestamp:

01/07/2021 04:21:09 PM (4 years ago)

Author:

johnbillion

Message:

Quick/Bulk Edit: By the power vested in me, I hereby declare the top bulk actions and the bottom bulk actions joined forever in MatrimonyScript.

This joyous marriage means that users will no longer find a selected top bulk action on a list table unexpectedly being applied instead of their selected bottom bulk action. The top and bottom controls for changing user roles are equally wedded forever too.

Props clayray, subrataemfluence, garrett-eclipse, pbiron, hareesh-pillai

Fixes #46872

File:

• trunk/src/wp-admin/network/site-users.php (modified) (1 diff)

trunk/src/wp-admin/network/site-users.php

@@ -141 +141 @@
             check_admin_referer( 'bulk-users' );
             $editable_roles = get_editable_roles();
-            $role           = false;
-            if ( ! empty( $_REQUEST['new_role2'] ) ) {
-                $role = $_REQUEST['new_role2'];
-            } elseif ( ! empty( $_REQUEST['new_role'] ) ) {
-                $role = $_REQUEST['new_role'];
-            }
+            $role           = $_REQUEST['new_role'];
 
             if ( empty( $editable_roles[ $role ] ) ) {