Changeset 49982

Timestamp:

01/19/2021 11:48:59 AM (4 years ago)

Author:

gziolo

Message:

Blocks: Add automatic RTL handlind for block styles registered from metadata

Related Gutenberg issue: ​https://github.com/WordPress/gutenberg/pull/28274

With this change it is going to be possible to use the same pattern that wp_style_add_data uses for RTL handling. If the block style file with "-rtl.css" is included in addition to the regular style referenced in "block.json" file then it is going to be automatically registered.

Props swisspidy, aristath.
See #52301.

Location:

trunk

Files:

• src/wp-includes/blocks.php (modified) (1 diff)
• tests/phpunit/data/blocks/notice/block-rtl.css (added)
• tests/phpunit/tests/blocks/register.php (modified) (1 diff)

trunk/src/wp-includes/blocks.php

@@ -170 +170 @@
     $style_handle = generate_block_asset_handle( $metadata['name'], $field_name );
     $block_dir    = dirname( $metadata['file'] );
+    $style_file   = realpath( "$block_dir/$style_path" );
     $result       = wp_register_style(
         $style_handle,
         plugins_url( $style_path, $metadata['file'] ),
         array(),
-        filemtime( realpath( "$block_dir/$style_path" ) )
-    );
+        filemtime( $style_file )
+    );
+    if ( file_exists( str_replace( '.css', '-rtl.css', $style_file ) ) ) {
+        wp_style_add_data( $style_handle, 'rtl', 'replace' );
+    }
+
     return $result ? $style_handle : false;
 }

trunk/tests/phpunit/tests/blocks/register.php

@@ -270 +270 @@
 
         $this->assertSame( 'unit-tests-test-block-style', $result );
+        $this->assertSame( 'replace', wp_styles()->get_data( 'unit-tests-test-block-style', 'rtl' ) );
     }