Changeset 49995

Timestamp:

01/21/2021 12:20:05 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Media: Use consistent method for instantiating an attachment author object in Media Library.

Previously, attachments without an author could cause a PHP fatal error due to calling the ::exists() method on a false value.

Follow-up to [49207].

Props antpb, carloscastilloadhoc, hellofromTonya, garrett-eclipse.
Merges [49979] to the 5.6 branch.
Fixes #52030.

Location:

branches/5.6

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/media.php (modified) (1 diff)
• src/wp-includes/media.php (modified) (1 diff)

branches/5.6/src/wp-admin/includes/media.php

@@ -3289 +3289 @@
     $att_url = wp_get_attachment_url( $attachment_id );
 
-    $author = get_userdata( $post->post_author );
+    $author = new WP_User( $post->post_author );
 
     $uploaded_by_name = __( '(no author)' );
     $uploaded_by_link = '';
+
     if ( $author->exists() ) {
         $uploaded_by_name = $author->display_name ? $author->display_name : $author->nickname;

branches/5.6/src/wp-includes/media.php

@@ -3862 +3862 @@
 
     $author = new WP_User( $attachment->post_author );
+
     if ( $author->exists() ) {
         $author_name            = $author->display_name ? $author->display_name : $author->nickname;