Changeset 49996

Timestamp:

01/21/2021 12:29:12 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Editor: Trigger the tinymce-editor-init custom jQuery event on DOM ready.

Otherwise TinyMCE may initialize earlier and handlers attached on DOM ready may not get triggered. Fixes making the editor menu "sticky" and setting/resetting some screen options on the old Edit Post screen.

Props azaozz, majhajob, sabernhardt.
Merges [49911] to the 5.6 branch.
Fixes #52046, #51995.

Location:

branches/5.6

Files:

• . (modified) (1 prop)
• src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js (modified) (2 diffs)

branches/5.6/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js

@@ -17 +17 @@
 
     if ( $ ) {
+        // Runs as soon as TinyMCE has started initializing, while plugins are loading.
+        // Handlers attached after the `tinymce.init()` call may not get triggered for this instance.
         $( document ).triggerHandler( 'tinymce-editor-setup', [ editor ] );
     }
@@ -541 +543 @@
 
         if ( $ ) {
-            $( document ).triggerHandler( 'tinymce-editor-init', [editor] );
+            // Run on DOM ready. Otherwise TinyMCE may initialize earlier and handlers attached
+            // on DOM ready of after the `tinymce.init()` call may not get triggered.
+            $( function() {
+                $( document ).triggerHandler( 'tinymce-editor-init', [editor] );
+            });
         }