Changeset 50040 for branches/5.6

Timestamp:

01/28/2021 12:08:48 AM (4 years ago)

Author:

whyisjake

Message:

Media: Ensure that wp_get_attachment_metadata can return values from the global $post, if avaiable.

In [49084] (for #50679), wp_get_attachment_metadata() was changed to improve performance, but it had the side effect of eliminating the ability to call it with no arguments and have it default to using the global $post.

This change restores that ability, while keeping the performance improvements from the original change.

This changeset brings [50039] to the 5.6 branch.

Fixes #52196.
Props cfinke, hellofromTonya, mukesh27, dilipbheda, Mista-Flo, audrasjb, SergeyBiryukov, whyisjake.

Location:

branches/5.6

Files:

• . (modified) (1 prop)
• src/wp-includes/post.php (modified) (2 diffs)

branches/5.6/src/wp-includes/post.php

@@ -6072 +6072 @@
  * @since 2.1.0
  *
- * @param int  $attachment_id Attachment post ID. Defaults to global $post.
+ * @param int  $attachment_id Attachment post ID. Default 0.
  * @param bool $unfiltered    Optional. If true, filters are not run. Default false.
  * @return array|false {
@@ -6087 +6087 @@
 function wp_get_attachment_metadata( $attachment_id = 0, $unfiltered = false ) {
     $attachment_id = (int) $attachment_id;
+
+    if ( ! $attachment_id ) {
+        $post = get_post();
+
+        if ( ! $post ) {
+            return false;
+        }
+
+        $attachment_id = $post->ID;
+    }
 
     $data = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );