WordPress.org

Make WordPress Core

Changeset 50041


Ignore:
Timestamp:
01/28/2021 12:16:21 AM (3 months ago)
Author:
whyisjake
Message:

Site Health: Update php update strings to not overpromise performance.

Fixes #52327.

Props chanthaboune, SergeyBiryukov, audrasjb, Clorith, whyisjake.

Location:
trunk/src/wp-admin/includes
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-site-health.php

    r49917 r50041  
    727727                sprintf(
    728728                    /* translators: %s: The minimum recommended PHP version. */
    729                     __( 'PHP is the programming language used to build and maintain WordPress. Newer versions of PHP are faster and more secure, so staying up to date will help your site’s overall performance and security. The minimum recommended version of PHP is %s.' ),
     729                    __( 'PHP is the programming language used to build and maintain WordPress. Newer versions of PHP are created with increased performance in mind, so you may see a positive effect on your site’s performance. The minimum recommended version of PHP is %s.' ),
    730730                    $response ? $response['recommended_version'] : ''
    731731                )
  • trunk/src/wp-admin/includes/dashboard.php

    r49936 r50041  
    4040    if ( $response && isset( $response['is_acceptable'] ) && ! $response['is_acceptable'] && current_user_can( 'update_php' ) ) {
    4141        add_filter( 'postbox_classes_dashboard_dashboard_php_nag', 'dashboard_php_nag_class' );
    42         wp_add_dashboard_widget( 'dashboard_php_nag', __( 'PHP Update Required' ), 'wp_dashboard_php_nag' );
     42        wp_add_dashboard_widget( 'dashboard_php_nag', __( 'PHP Update Recommended' ), 'wp_dashboard_php_nag' );
    4343    }
    4444
     
    17481748
    17491749    if ( isset( $response['is_secure'] ) && ! $response['is_secure'] ) {
    1750         $msg = __( 'WordPress has detected that your site is running on an insecure version of PHP.' );
     1750        $msg = sprintf(
     1751            /* translators: %s: The server PHP version. */
     1752            __( 'Your site is running an insecure version of PHP (%s), and should be updated.' ),
     1753            PHP_VERSION
     1754        );
    17511755    } else {
    1752         $msg = __( 'WordPress has detected that your site is running on an outdated version of PHP.' );
    1753     }
    1754 
     1756        $msg = sprintf(
     1757            /* translators: %s: The server PHP version. */
     1758            __( 'Your site is running an outdated version of PHP (%s), and should be updated.' ),
     1759            PHP_VERSION
     1760        );
     1761    }
    17551762    ?>
    17561763    <p><?php echo $msg; ?></p>
    17571764
    17581765    <h3><?php _e( 'What is PHP and how does it affect my site?' ); ?></h3>
    1759     <p><?php _e( 'PHP is the programming language we use to build and maintain WordPress. Newer versions of PHP are both faster and more secure, so updating will have a positive effect on your site&#8217;s performance.' ); ?></p>
     1766    <p>
     1767        <?php
     1768        printf(
     1769            /* translators: %s: The minimum recommended PHP version. */
     1770            __( 'PHP is the programming language used to build and maintain WordPress. Newer versions of PHP are created with increased performance in mind, so you may see a positive effect on your site&#8217;s performance. The minimum recommended version of PHP is %s.' ),
     1771            $response ? $response['recommended_version'] : ''
     1772        );
     1773        ?>
     1774    </p>
    17601775
    17611776    <p class="button-container">
Note: See TracChangeset for help on using the changeset viewer.