Changeset 50041 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

01/28/2021 12:16:21 AM (4 years ago)

Author:

whyisjake

Message:

Site Health: Update php update strings to not overpromise performance.

Fixes #52327.

Props chanthaboune, SergeyBiryukov, audrasjb, Clorith, whyisjake.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (2 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -40 +40 @@
     if ( $response && isset( $response['is_acceptable'] ) && ! $response['is_acceptable'] && current_user_can( 'update_php' ) ) {
         add_filter( 'postbox_classes_dashboard_dashboard_php_nag', 'dashboard_php_nag_class' );
-        wp_add_dashboard_widget( 'dashboard_php_nag', __( 'PHP Update Required' ), 'wp_dashboard_php_nag' );
+        wp_add_dashboard_widget( 'dashboard_php_nag', __( 'PHP Update Recommended' ), 'wp_dashboard_php_nag' );
     }
 
@@ -1748 +1748 @@
 
     if ( isset( $response['is_secure'] ) && ! $response['is_secure'] ) {
-        $msg = __( 'WordPress has detected that your site is running on an insecure version of PHP.' );
+        $msg = sprintf(
+            /* translators: %s: The server PHP version. */
+            __( 'Your site is running an insecure version of PHP (%s), and should be updated.' ),
+            PHP_VERSION
+        );
     } else {
-        $msg = __( 'WordPress has detected that your site is running on an outdated version of PHP.' );
-    }
-
+        $msg = sprintf(
+            /* translators: %s: The server PHP version. */
+            __( 'Your site is running an outdated version of PHP (%s), and should be updated.' ),
+            PHP_VERSION
+        );
+    }
     ?>
     <p><?php echo $msg; ?></p>
 
     <h3><?php _e( 'What is PHP and how does it affect my site?' ); ?></h3>
-    <p><?php _e( 'PHP is the programming language we use to build and maintain WordPress. Newer versions of PHP are both faster and more secure, so updating will have a positive effect on your site&#8217;s performance.' ); ?></p>
+    <p>
+        <?php
+        printf(
+            /* translators: %s: The minimum recommended PHP version. */
+            __( 'PHP is the programming language used to build and maintain WordPress. Newer versions of PHP are created with increased performance in mind, so you may see a positive effect on your site&#8217;s performance. The minimum recommended version of PHP is %s.' ),
+            $response ? $response['recommended_version'] : ''
+        );
+        ?>
+    </p>
 
     <p class="button-container">