Changeset 50067

Timestamp:

01/29/2021 01:34:05 AM (6 years ago)

Author:

antpb

Message:

Media: Remove caching from filter by date in media library.

Previously, newly uploaded media attachments were missing when filtering media items by date due to lack of cache invalidation.

Props adamsilverstein, teamdnk, afercia, Mista-Flo, joedolson, youknowriad, talldanwp.
Fixes #50025.

Location:

trunk/src/js/media/models

Files:

• attachments.js (modified) (1 diff)
• query.js (modified) (3 diffs)

trunk/src/js/media/models/attachments.js

@@ -391 +391 @@
                 if ( this.props.get('query') ) {
                         props = this.props.toJSON();
-                        props.cache = ( true !== refresh );
                         this.mirror( wp.media.model.Query.get( props ) );
                 }

trunk/src/js/media/models/query.js

@@ -214 +214 @@
          *
          * @param {object} [props]
-         * @param {Object} [props.cache=true]   Whether to use the query cache or not.
          * @param {Object} [props.order]
          * @param {Object} [props.orderby]
@@ -244 +243 @@
                                 orderby  = Query.orderby,
                                 defaults = Query.defaultProps,
-                                query,
-                                cache    = !! props.cache || _.isUndefined( props.cache );
+                                query;
 
                         // Remove the `query` property. This isn't linked to a query,
                         // this *is* the query.
                         delete props.query;
-                        delete props.cache;
 
                         // Fill default args.
@@ -289 +286 @@
                         args.orderby = orderby.valuemap[ props.orderby ] || props.orderby;
 
-                        // Search the query cache for a matching query.
-                        if ( cache ) {
-                                query = _.find( queries, function( query ) {
-                                        return _.isEqual( query.args, args );
-                                });
-                        } else {
-                                queries = [];
-                        }
+                        queries = [];
 
                         // Otherwise, create a new query and add it to the cache.