Changeset 50072 for trunk/tests/phpunit/tests/https-detection.php

Timestamp:

01/29/2021 07:09:49 PM (6 years ago)

Author:

flixos90

Message:

Security, Site Health: Improve accuracy in messaging about HTTPS support.

Following up on [49904], this changeset focuses mainly on improving the guidance about the current state of HTTPS in Site Health.

• Correct the existing copy to indicate that both the Site Address and the WordPress Address need to be changed to fully switch to HTTPS.
• Link to the respective input fields via anchor links rather than to the overall General Settings screen.
• Show different copy if the site is using HTTPS for the WordPress Address (for example to have only the administration panel in HTTPS), but not for the Site Address.
• Inform the user about potential problems even when the site is already using HTTPS, for example if the SSL certificate was no longer valid.
• Always rely on fresh information for determining HTTPS support issues in Site Health, and therefore change the https_status test to become asynchronous.
• Rename the new private wp_is_owned_html_output() function to a more appropriate wp_is_local_html_output().

Props adamsilverstein, flixos90, johnjamesjacoby, timothyblynjacobs.
See #47577.

File:

• trunk/tests/phpunit/tests/https-detection.php (modified) (6 diffs)

trunk/tests/phpunit/tests/https-detection.php

@@ -142 +142 @@
          * @ticket 47577
          */
-        public function test_wp_is_owned_html_output_via_rsd_link() {
+        public function test_wp_is_local_html_output_via_rsd_link() {
                 // HTML includes RSD link.
                 $head_tag = get_echo( 'rsd_link' );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML includes modified RSD link but same URL.
                 $head_tag = str_replace( ' />', '>', get_echo( 'rsd_link' ) );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML does not include RSD link.
                 $html = $this->get_sample_html_string();
-                $this->assertFalse( wp_is_owned_html_output( $html ) );
-        }
-
-        /**
-         * @ticket 47577
-         */
-        public function test_wp_is_owned_html_output_via_wlwmanifest_link() {
+                $this->assertFalse( wp_is_local_html_output( $html ) );
+        }
+
+        /**
+         * @ticket 47577
+         */
+        public function test_wp_is_local_html_output_via_wlwmanifest_link() {
                 remove_action( 'wp_head', 'rsd_link' );
 
@@ -167 +167 @@
                 $head_tag = get_echo( 'wlwmanifest_link' );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML includes modified WLW manifest link but same URL.
                 $head_tag = str_replace( ' />', '>', get_echo( 'wlwmanifest_link' ) );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML includes WLW manifest link with alternative URL scheme.
@@ -178 +178 @@
                 $head_tag = false !== strpos( $head_tag, 'https://' ) ? str_replace( 'https://', 'http://', $head_tag ) : str_replace( 'http://', 'https://', $head_tag );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML does not include WLW manifest link.
                 $html = $this->get_sample_html_string();
-                $this->assertFalse( wp_is_owned_html_output( $html ) );
-        }
-
-        /**
-         * @ticket 47577
-         */
-        public function test_wp_is_owned_html_output_via_rest_link() {
+                $this->assertFalse( wp_is_local_html_output( $html ) );
+        }
+
+        /**
+         * @ticket 47577
+         */
+        public function test_wp_is_local_html_output_via_rest_link() {
                 remove_action( 'wp_head', 'rsd_link' );
                 remove_action( 'wp_head', 'wlwmanifest_link' );
@@ -195 +195 @@
                 $head_tag = get_echo( 'rest_output_link_wp_head' );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML includes modified REST API link but same URL.
                 $head_tag = str_replace( ' />', '>', get_echo( 'rest_output_link_wp_head' ) );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML includes REST API link with alternative URL scheme.
@@ -206 +206 @@
                 $head_tag = false !== strpos( $head_tag, 'https://' ) ? str_replace( 'https://', 'http://', $head_tag ) : str_replace( 'http://', 'https://', $head_tag );
                 $html     = $this->get_sample_html_string( $head_tag );
-                $this->assertTrue( wp_is_owned_html_output( $html ) );
+                $this->assertTrue( wp_is_local_html_output( $html ) );
 
                 // HTML does not include REST API link.
                 $html = $this->get_sample_html_string();
-                $this->assertFalse( wp_is_owned_html_output( $html ) );
-        }
-
-        /**
-         * @ticket 47577
-         */
-        public function test_wp_is_owned_html_output_cannot_determine() {
+                $this->assertFalse( wp_is_local_html_output( $html ) );
+        }
+
+        /**
+         * @ticket 47577
+         */
+        public function test_wp_is_local_html_output_cannot_determine() {
                 remove_action( 'wp_head', 'rsd_link' );
                 remove_action( 'wp_head', 'wlwmanifest_link' );
@@ -223 +223 @@
                 // The HTML here doesn't matter because all hooks are removed.
                 $html = $this->get_sample_html_string();
-                $this->assertNull( wp_is_owned_html_output( $html ) );
+                $this->assertNull( wp_is_local_html_output( $html ) );
         }