Changeset 50075 for trunk/tests/phpunit/tests/https-detection.php

Timestamp:

01/29/2021 07:58:39 PM (4 years ago)

Author:

flixos90

Message:

Security: Allow short-circuiting the wp_update_https_detection_errors() process.

This changeset introduces a pre_wp_update_https_detection_errors filter which can be used to short-circuit the default logic for detecting problems with HTTPS support for the site, by returning a WP_Error object.

Props timothyblynjacobs.
See #47577.

File:

• trunk/tests/phpunit/tests/https-detection.php (modified) (1 diff)

trunk/tests/phpunit/tests/https-detection.php

@@ -108 +108 @@
         // Check that the requests are made to the correct URL.
         $this->assertEquals( 'https://example.com/', $this->last_request_url );
+    }
+
+    /**
+     * @ticket 47577
+     */
+    public function test_pre_wp_update_https_detection_errors() {
+        // Override to enforce no errors being detected.
+        add_filter(
+            'pre_wp_update_https_detection_errors',
+            function() {
+                return new WP_Error();
+            }
+        );
+        wp_update_https_detection_errors();
+        $this->assertEquals( array(), get_option( 'https_detection_errors' ) );
+
+        // Override to enforce an error being detected.
+        add_filter(
+            'pre_wp_update_https_detection_errors',
+            function() {
+                return new WP_Error(
+                    'ssl_verification_failed',
+                    'Bad SSL certificate.'
+                );
+            }
+        );
+        wp_update_https_detection_errors();
+        $this->assertEquals(
+            array( 'ssl_verification_failed' => array( 'Bad SSL certificate.' ) ),
+            get_option( 'https_detection_errors' )
+        );
     }