Changeset 50096 for branches/4.9/tests/phpunit/tests/external-http/basic.php

Timestamp:

01/30/2021 03:14:16 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Skip test_readme() if the HTTP request to secure.php.net or dev.mysql.com failed on timeout.

Move skipTestOnTimeout() to WP_UnitTestCase_Base to avoid duplication.

Merges [46682] and [46996] to the 4.9 branch.
See #51669.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/external-http/basic.php (modified) (2 diffs)

branches/4.9/tests/phpunit/tests/external-http/basic.php

@@ -14 +14 @@
 
                 $response = wp_remote_get( 'https://secure.php.net/supported-versions.php' );
-                if ( 200 != wp_remote_retrieve_response_code( $response ) ) {
-                        $this->fail( 'Could not contact PHP.net to check versions.' );
+
+                $this->skipTestOnTimeout( $response );
+
+                $response_code = wp_remote_retrieve_response_code( $response );
+                if ( 200 !== $response_code ) {
+                        $this->fail( sprintf( 'Could not contact PHP.net to check versions. Response code: %s', $response_code ) );
                 }
+
                 $php = wp_remote_retrieve_body( $response );
 
@@ -26 +31 @@
 
                 $response = wp_remote_get( "https://dev.mysql.com/doc/relnotes/mysql/{$matches[1]}/en/" );
-                if ( 200 != wp_remote_retrieve_response_code( $response ) ) {
-                        $this->fail( 'Could not contact dev.MySQL.com to check versions.' );
+
+                $this->skipTestOnTimeout( $response );
+
+                $response_code = wp_remote_retrieve_response_code( $response );
+                if ( 200 !== $response_code ) {
+                        $this->fail( sprintf( 'Could not contact dev.MySQL.com to check versions. Response code: %s', $response_code ) );
                 }
+
                 $mysql = wp_remote_retrieve_body( $response );