Changeset 50114 for trunk/tests/phpunit/tests/rest-api/rest-application-passwords-controller.php

Timestamp:

01/31/2021 07:02:30 PM (6 years ago)

Author:

TimothyBlynJacobs

Message:

App Passwords: Introduce fine grained capabilities.

Previously, all permission checks for using app passwords were implemented using edit_user. This commit introduces a series of more fine grained meta capabilities that should be used instead: create_app_password, list_app_passwords, read_app_password, edit_app_password, delete_app_password and delete_app_passwords. These capabilities all map to edit_user by default, but may now be customized by developers.

Props johnbillion, TimothyBlynJacobs.
Fixes #51703.

File:

• trunk/tests/phpunit/tests/rest-api/rest-application-passwords-controller.php (modified) (6 diffs)

trunk/tests/phpunit/tests/rest-api/rest-application-passwords-controller.php

@@ -191 +191 @@
 
                 $response = rest_do_request( sprintf( '/wp/v2/users/%d/application-passwords', self::$admin ) );
-                $this->assertErrorResponse( 'rest_cannot_manage_application_passwords', $response, 403 );
+                $this->assertErrorResponse( 'rest_cannot_list_application_passwords', $response, 403 );
         }
 
@@ -273 +273 @@
                 $uuid     = $item['uuid'];
                 $response = rest_do_request( sprintf( '/wp/v2/users/%d/application-passwords/%s', self::$admin, $uuid ) );
-                $this->assertErrorResponse( 'rest_cannot_manage_application_passwords', $response, 403 );
+                $this->assertErrorResponse( 'rest_cannot_read_application_password', $response, 403 );
         }
 
@@ -395 +395 @@
                 $request->set_body_params( array( 'name' => 'App' ) );
                 $response = rest_do_request( $request );
-                $this->assertErrorResponse( 'rest_cannot_manage_application_passwords', $response, 403 );
+                $this->assertErrorResponse( 'rest_cannot_create_application_passwords', $response, 403 );
         }
 
@@ -501 +501 @@
                 $request->set_body_params( array( 'name' => 'New App' ) );
                 $response = rest_do_request( $request );
-                $this->assertErrorResponse( 'rest_cannot_manage_application_passwords', $response, 403 );
+                $this->assertErrorResponse( 'rest_cannot_edit_application_password', $response, 403 );
         }
 
@@ -644 +644 @@
                 $request  = new WP_REST_Request( 'DELETE', sprintf( '/wp/v2/users/%d/application-passwords/%s', self::$admin, $uuid ) );
                 $response = rest_do_request( $request );
-                $this->assertErrorResponse( 'rest_cannot_manage_application_passwords', $response, 403 );
+                $this->assertErrorResponse( 'rest_cannot_delete_application_password', $response, 403 );
         }
 
@@ -748 +748 @@
                 $request  = new WP_REST_Request( 'DELETE', sprintf( '/wp/v2/users/%d/application-passwords', self::$admin ) );
                 $response = rest_do_request( $request );
-                $this->assertErrorResponse( 'rest_cannot_manage_application_passwords', $response, 403 );
+                $this->assertErrorResponse( 'rest_cannot_delete_application_passwords', $response, 403 );
         }