Changeset 50120

Timestamp:

02/01/2021 02:11:57 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Introduce "Filter by date" and "Filter by category" as post type and taxonomy labels, respectively.

This provides a more consistent location for these strings and allows for reusing them in other places without hardcoding them in the markup.

Props nicolalaserra, audrasjb, johnjamesjacoby, SergeyBiryukov.
Fixes #42421.

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-links-list-table.php (modified) (1 diff)
• wp-admin/includes/class-wp-list-table.php (modified) (1 diff)
• wp-admin/includes/class-wp-posts-list-table.php (modified) (1 diff)
• wp-includes/post.php (modified) (3 diffs)
• wp-includes/taxonomy.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-links-list-table.php

@@ -115 +115 @@
             );
 
-            echo '<label class="screen-reader-text" for="cat_id">' . __( 'Filter by category' ) . '</label>';
+            echo '<label class="screen-reader-text" for="cat_id">' . get_taxonomy( 'link_category' )->labels->filter_by_item . '</label>';
 
             wp_dropdown_categories( $dropdown_options );

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -634 +634 @@
         $m = isset( $_GET['m'] ) ? (int) $_GET['m'] : 0;
         ?>
-        <label for="filter-by-date" class="screen-reader-text"><?php _e( 'Filter by date' ); ?></label>
+        <label for="filter-by-date" class="screen-reader-text"><?php echo get_post_type_object( $post_type )->labels->filter_by_date; ?></label>
         <select name="m" id="filter-by-date">
             <option<?php selected( $m, 0 ); ?> value="0"><?php _e( 'All dates' ); ?></option>

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -457 +457 @@
             );
 
-            echo '<label class="screen-reader-text" for="cat">' . __( 'Filter by category' ) . '</label>';
+            echo '<label class="screen-reader-text" for="cat">' . get_taxonomy( 'category' )->labels->filter_by_item . '</label>';
+
             wp_dropdown_categories( $dropdown_options );
         }

trunk/src/wp-includes/post.php

@@ -1690 +1690 @@
  * - `filter_items_list` - Label for the table views hidden heading. Default is 'Filter posts list' /
  *                       'Filter pages list'.
+ * - `filter_by_date` - Label for the date filter in list tables. Default is 'Filter by date'.
  * - `items_list_navigation` - Label for the table pagination hidden heading. Default is 'Posts list navigation' /
  *                           'Pages list navigation'.
@@ -1716 +1717 @@
  * @since 5.0.0 Added the `item_published`, `item_published_privately`, `item_reverted_to_draft`,
  *              `item_scheduled`, and `item_updated` labels.
+ * @since 5.7.0 Added the `filter_by_date` label.
  *
  * @access private
@@ -1746 +1748 @@
         'use_featured_image'       => array( _x( 'Use as featured image', 'post' ), _x( 'Use as featured image', 'page' ) ),
         'filter_items_list'        => array( __( 'Filter posts list' ), __( 'Filter pages list' ) ),
+        'filter_by_date'           => array( __( 'Filter by date' ), __( 'Filter by date' ) ),
         'items_list_navigation'    => array( __( 'Posts list navigation' ), __( 'Pages list navigation' ) ),
         'items_list'               => array( __( 'Posts list' ), __( 'Pages list' ) ),

trunk/src/wp-includes/taxonomy.php

@@ -538 +538 @@
  * @since 4.4.0 Added the `items_list_navigation` and `items_list` labels.
  * @since 4.9.0 Added the `most_used` and `back_to_items` labels.
+ * @since 5.7.0 Added the `filter_by_item` label.
  *
  * @param WP_Taxonomy $tax Taxonomy object.
@@ -570 +571 @@
  *     @type string $no_terms                   Default 'No tags'/'No categories', used in the posts and media
  *                                              list tables.
+ *     @type string $filter_by_item             This label is only used for hierarchical taxonomies. Default
+ *                                              'Filter by category', used in the posts list table.
  *     @type string $items_list_navigation      Label for the table pagination hidden heading.
  *     @type string $items_list                 Label for the table hidden heading.
@@ -605 +608 @@
         'not_found'                  => array( __( 'No tags found.' ), __( 'No categories found.' ) ),
         'no_terms'                   => array( __( 'No tags' ), __( 'No categories' ) ),
+        'filter_by_item'             => array( null, __( 'Filter by category' ) ),
         'items_list_navigation'      => array( __( 'Tags list navigation' ), __( 'Categories list navigation' ) ),
         'items_list'                 => array( __( 'Tags list' ), __( 'Categories list' ) ),