Changeset 50146 for trunk/src/wp-admin/includes/class-custom-image-header.php

Timestamp:

02/02/2021 04:51:17 PM (4 years ago)

Author:

antpb

Message:

Media: Avoid suppressing errors when using getimagesize().

Previously, all logic utilizing getimagesize() was supressing errors making it difficult to debug usage of the function.

A new wp_getimagesize() function has been added to allow the errors to no longer be suppressed when WP_DEBUG is enabled.

Props Howdy_McGee, SergeyBiryukov, mukesh27, davidbaumwald, noisysocks, hellofromTonya.
Fixes #49889.

File:

• trunk/src/wp-admin/includes/class-custom-image-header.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-custom-image-header.php

@@ -792 +792 @@
 
         if ( file_exists( $file ) ) {
-            list( $width, $height, $type, $attr ) = @getimagesize( $file );
+            list( $width, $height, $type, $attr ) = wp_getimagesize( $file );
         } else {
             $data   = wp_get_attachment_metadata( $attachment_id );
@@ -1224 +1224 @@
         $url        = str_replace( wp_basename( $parent_url ), wp_basename( $cropped ), $parent_url );
 
-        $size       = @getimagesize( $cropped );
+        $size       = wp_getimagesize( $cropped );
         $image_type = ( $size ) ? $size['mime'] : 'image/jpeg';