Changeset 50146 for trunk/src/wp-admin/includes/class-wp-site-icon.php

Timestamp:

02/02/2021 04:51:17 PM (4 years ago)

Author:

antpb

Message:

Media: Avoid suppressing errors when using getimagesize().

Previously, all logic utilizing getimagesize() was supressing errors making it difficult to debug usage of the function.

A new wp_getimagesize() function has been added to allow the errors to no longer be suppressed when WP_DEBUG is enabled.

Props Howdy_McGee, SergeyBiryukov, mukesh27, davidbaumwald, noisysocks, hellofromTonya.
Fixes #49889.

File:

• trunk/src/wp-admin/includes/class-wp-site-icon.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-icon.php

@@ -88 +88 @@
         $url        = str_replace( wp_basename( $parent_url ), wp_basename( $cropped ), $parent_url );
 
-        $size       = @getimagesize( $cropped );
+        $size       = wp_getimagesize( $cropped );
         $image_type = ( $size ) ? $size['mime'] : 'image/jpeg';