Changeset 50146 for trunk/src/wp-includes/media.php

Timestamp:

02/02/2021 04:51:17 PM (4 years ago)

Author:

antpb

Message:

Media: Avoid suppressing errors when using getimagesize().

Previously, all logic utilizing getimagesize() was supressing errors making it difficult to debug usage of the function.

A new wp_getimagesize() function has been added to allow the errors to no longer be suppressed when WP_DEBUG is enabled.

Props Howdy_McGee, SergeyBiryukov, mukesh27, davidbaumwald, noisysocks, hellofromTonya.
Fixes #49889.

File:

• trunk/src/wp-includes/media.php (modified) (2 diffs)

trunk/src/wp-includes/media.php

@@ -245 +245 @@
 
         if ( $thumb_file ) {
-            $info = @getimagesize( $thumb_file );
+            $info = wp_getimagesize( $thumb_file );
         }
 
@@ -963 +963 @@
 
                 $src_file               = $icon_dir . '/' . wp_basename( $src );
-                list( $width, $height ) = @getimagesize( $src_file );
+                list( $width, $height ) = wp_getimagesize( $src_file );
             }
         }