Changeset 50150 for trunk/src/wp-includes/rest-api/class-wp-rest-server.php

Timestamp:

02/02/2021 05:26:06 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Return detailed error information from request validation.

Previously, only the first error message for each parameter was made available. Now, all error messages for a parameter are concatenated. Additionally, the detailed error for each parameter is made available in a new details section of the validation error. Each error is formatted following the standard REST API error formatting.

The WP_REST_Server::error_to_response method has been abstracted out into a standalone function rest_convert_error_to_response to allow for reuse by WP_REST_Request. The formatted errors now also contain an additional_data property which contains the additional error data provided by WP_Error::get_all_error_data.

Props dlh, xkon, TimothyBlynJacobs.
Fixes #46191.

File:

• trunk/src/wp-includes/rest-api/class-wp-rest-server.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/class-wp-rest-server.php

@@ -197 +197 @@
      *
      * @since 4.4.0
+     * @since 5.7.0 Converted to a wrapper of {@see rest_convert_error_to_response()}.
      *
      * @param WP_Error $error WP_Error instance.
@@ -202 +203 @@
      */
     protected function error_to_response( $error ) {
-        $error_data = $error->get_error_data();
-
-        if ( is_array( $error_data ) && isset( $error_data['status'] ) ) {
-            $status = $error_data['status'];
-        } else {
-            $status = 500;
-        }
-
-        $errors = array();
-
-        foreach ( (array) $error->errors as $code => $messages ) {
-            foreach ( (array) $messages as $message ) {
-                $errors[] = array(
-                    'code'    => $code,
-                    'message' => $message,
-                    'data'    => $error->get_error_data( $code ),
-                );
-            }
-        }
-
-        $data = $errors[0];
-        if ( count( $errors ) > 1 ) {
-            // Remove the primary error.
-            array_shift( $errors );
-            $data['additional_errors'] = $errors;
-        }
-
-        $response = new WP_REST_Response( $data, $status );
-
-        return $response;
+        return rest_convert_error_to_response( $error );
     }