Changeset 50150 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

02/02/2021 05:26:06 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Return detailed error information from request validation.

Previously, only the first error message for each parameter was made available. Now, all error messages for a parameter are concatenated. Additionally, the detailed error for each parameter is made available in a new details section of the validation error. Each error is formatted following the standard REST API error formatting.

The WP_REST_Server::error_to_response method has been abstracted out into a standalone function rest_convert_error_to_response to allow for reuse by WP_REST_Request. The formatted errors now also contain an additional_data property which contains the additional error data provided by WP_Error::get_all_error_data.

Props dlh, xkon, TimothyBlynJacobs.
Fixes #46191.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -456 +456 @@
         $request->set_param( 'context', 'edit' );
         $response = rest_get_server()->dispatch( $request );
-        $data     = $response->get_data();
-        $this->assertCount( 3, $data );
-        $this->assertSame( 'rest_invalid_param', $data['code'] );
+        $this->assertErrorResponse( 'rest_invalid_param', $response );
     }