Changeset 50150 for trunk/tests/phpunit/tests/rest-api/rest-server.php

Timestamp:

02/02/2021 05:26:06 PM (6 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Return detailed error information from request validation.

Previously, only the first error message for each parameter was made available. Now, all error messages for a parameter are concatenated. Additionally, the detailed error for each parameter is made available in a new details section of the validation error. Each error is formatted following the standard REST API error formatting.

The WP_REST_Server::error_to_response method has been abstracted out into a standalone function rest_convert_error_to_response to allow for reuse by WP_REST_Request. The formatted errors now also contain an additional_data property which contains the additional error data provided by WP_Error::get_all_error_data.

Props dlh, xkon, TimothyBlynJacobs.
Fixes #46191.

File:

• trunk/tests/phpunit/tests/rest-api/rest-server.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-server.php

@@ -408 +408 @@
                 $error   = new WP_Error( $code, $message );
 
-                $response = rest_get_server()->error_to_response( $error );
+                $response = rest_convert_error_to_response( $error );
                 $this->assertInstanceOf( 'WP_REST_Response', $response );
 
@@ -425 +425 @@
                 $error   = new WP_Error( $code, $message, array( 'status' => 400 ) );
 
-                $response = rest_get_server()->error_to_response( $error );
+                $response = rest_convert_error_to_response( $error );
                 $this->assertInstanceOf( 'WP_REST_Response', $response );
 
@@ -444 +444 @@
                 $error->add( $code2, $message2, array( 'status' => 403 ) );
 
-                $response = rest_get_server()->error_to_response( $error );
+                $response = rest_convert_error_to_response( $error );
                 $this->assertInstanceOf( 'WP_REST_Response', $response );
 
@@ -455 +455 @@
                 $this->assertSame( $message2, $error->errors[ $code2 ][0] );
                 $this->assertSame( array( 'status' => 403 ), $error->error_data[ $code2 ] );
+        }
+
+        /**
+         * @ticket 46191
+         */
+        public function test_error_to_response_with_additional_data() {
+                $error = new WP_Error( 'test', 'test', array( 'status' => 400 ) );
+                $error->add_data( 'more_data' );
+
+                $response = rest_convert_error_to_response( $error );
+                $this->assertSame( 400, $response->get_status() );
+                $this->assertEquals( 'more_data', $response->get_data()['data'] );
+                $this->assertEquals( array( array( 'status' => 400 ) ), $response->get_data()['additional_data'] );
         }