Changeset 50163 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

02/02/2021 08:32:42 PM (4 years ago)

Author:

whyisjake

Message:

Administration: New filter ahead of the months drop-down.

As this can cause large, long running queries on sites with many posts, this filter allows the query to be modified, bypassing entirely if needed.

Fixes #51660.

Props geoffguillain, SergeyBiryukov, hareesh-pillai, hellofromTonya, TimothyBlynJacobs, whyisjake.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -596 +596 @@
         }
 
-        $extra_checks = "AND post_status != 'auto-draft'";
-        if ( ! isset( $_GET['post_status'] ) || 'trash' !== $_GET['post_status'] ) {
-            $extra_checks .= " AND post_status != 'trash'";
-        } elseif ( isset( $_GET['post_status'] ) ) {
-            $extra_checks = $wpdb->prepare( ' AND post_status = %s', $_GET['post_status'] );
-        }
-
-        $months = $wpdb->get_results(
-            $wpdb->prepare(
-                "
-            SELECT DISTINCT YEAR( post_date ) AS year, MONTH( post_date ) AS month
-            FROM $wpdb->posts
-            WHERE post_type = %s
-            $extra_checks
-            ORDER BY post_date DESC
-        ",
-                $post_type
-            )
-        );
-
         /**
-         * Filters the 'Months' drop-down results.
+         * Filters to short-circuit performing the months dropdown query.
          *
-         * @since 3.7.0
+         * @since 5.7.0
          *
-         * @param object[] $months    Array of the months drop-down query results.
-         * @param string   $post_type The post type.
+         * @param object[]|false $months   'Months' drop-down results. Default false.
+         * @param string         $post_type The post type.
          */
-        $months = apply_filters( 'months_dropdown_results', $months, $post_type );
+        $months = apply_filters( 'pre_months_dropdown_query', false, $post_type );
+
+        if ( ! is_array( $months ) ) {
+            $extra_checks = "AND post_status != 'auto-draft'";
+            if ( ! isset( $_GET['post_status'] ) || 'trash' !== $_GET['post_status'] ) {
+                $extra_checks .= " AND post_status != 'trash'";
+            } elseif ( isset( $_GET['post_status'] ) ) {
+                $extra_checks = $wpdb->prepare( ' AND post_status = %s', $_GET['post_status'] );
+            }
+
+            $months = $wpdb->get_results(
+                $wpdb->prepare(
+                    "
+                SELECT DISTINCT YEAR( post_date ) AS year, MONTH( post_date ) AS month
+                FROM $wpdb->posts
+                WHERE post_type = %s
+                $extra_checks
+                ORDER BY post_date DESC
+            ",
+                    $post_type
+                )
+            );
+
+            /**
+             * Filters the 'Months' drop-down results.
+             *
+             * @since 3.7.0
+             *
+             * @param object[] $months    Array of the months drop-down query results.
+             * @param string   $post_type The post type.
+             */
+            $months = apply_filters( 'months_dropdown_results', $months, $post_type );
+        }
 
         $month_count = count( $months );