Changeset 50269

Timestamp:

02/09/2021 02:54:48 PM (4 years ago)

Author:

desrosj

Message:

Twenty Twenty-One: Prevent Dark Mode related JavaScript error.

This prevents an Uncaught TypeError in the block editor when scrolling caused by the absence of a #dark-mode-toggler element.

Props ocean90, mukesh27, justinahinon.
Fixes #52473.

File:

• trunk/src/wp-content/themes/twentytwentyone/assets/js/dark-mode-toggler.js (modified) (2 diffs)

trunk/src/wp-content/themes/twentytwentyone/assets/js/dark-mode-toggler.js

@@ -45 +45 @@
 
 function darkModeRepositionTogglerOnScroll() {
-    var prevScroll = window.scrollY || document.documentElement.scrollTop,
+
+    var toggler = document.getElementById( 'dark-mode-toggler' ),
+        prevScroll = window.scrollY || document.documentElement.scrollTop,
         currentScroll,
 
@@ -54 +56 @@
                 currentScroll < prevScroll
             ) {
-                document.getElementById( 'dark-mode-toggler' ).classList.remove( 'hide' );
+                toggler.classList.remove( 'hide' );
             } else if ( currentScroll > prevScroll && 250 < currentScroll ) {
-                document.getElementById( 'dark-mode-toggler' ).classList.add( 'hide' );
+                toggler.classList.add( 'hide' );
             }
             prevScroll = currentScroll;
         };
-    window.addEventListener( 'scroll', checkScroll );
+
+    if ( toggler ) {
+        window.addEventListener( 'scroll', checkScroll );
+    }
 }