Changeset 50271 for trunk/src/wp-includes/class-wp.php

Timestamp:

02/09/2021 04:55:29 PM (4 years ago)

Author:

johnbillion

Message:

Comments: Extend the duration of the window within which unapproved comments are visible by their author.

This extension is necessary because the comment approval notification opt-in form introduced in [47887] uses the same mechanism, and the previous limit of one minute meant that users on a slow connection, using assistive technology, with limited motor skills, or who are generally indecisive may not complete the opt-in action within one minute, and therefore not see the confirmation message.

Props joedolson, imath, hellofromTonya, peterwilsoncc, alexstine, davidbaumwald 

Fixes #52406

File:

• trunk/src/wp-includes/class-wp.php (modified) (1 diff)

trunk/src/wp-includes/class-wp.php

@@ -406 +406 @@
             $headers = array_merge( $headers, wp_get_nocache_headers() );
         } elseif ( ! empty( $_GET['unapproved'] ) && ! empty( $_GET['moderation-hash'] ) ) {
-            // Unmoderated comments are only visible for one minute via the moderation hash.
-            $headers['Expires']       = gmdate( 'D, d M Y H:i:s', time() + MINUTE_IN_SECONDS );
-            $headers['Cache-Control'] = 'max-age=60, must-revalidate';
+            // Unmoderated comments are only visible for 10 minutes via the moderation hash.
+            $expires = 10 * MINUTE_IN_SECONDS;
+
+            $headers['Expires']       = gmdate( 'D, d M Y H:i:s', time() + $expires );
+            $headers['Cache-Control'] = sprintf(
+                'max-age=%d, must-revalidate',
+                $expires
+            );
         }
         if ( ! empty( $this->query_vars['error'] ) ) {