Changeset 50283 for trunk/tests/phpunit/includes/testcase-canonical.php

Timestamp:

02/10/2021 01:23:42 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Replace most instances of assertEquals() in phpunit/includes/ with assertSame().

Follow-up to [48937], [48939], [48940], [48944].

Props johnbillion, jrf, SergeyBiryukov.
See #38266, #52482.

File:

• trunk/tests/phpunit/includes/testcase-canonical.php (modified) (2 diffs)

trunk/tests/phpunit/includes/testcase-canonical.php

@@ -309 +309 @@
         // Just test the path and query if present.
         if ( isset( $expected['url'] ) ) {
-            $this->assertEquals( $expected['url'], $parsed_can_url['path'] . ( ! empty( $parsed_can_url['query'] ) ? '?' . $parsed_can_url['query'] : '' ), $ticket_ref );
+            $this->assertSame( $expected['url'], $parsed_can_url['path'] . ( ! empty( $parsed_can_url['query'] ) ? '?' . $parsed_can_url['query'] : '' ), $ticket_ref );
         }
 
@@ -329 +329 @@
             // $_qv should not contain any elements which are set in $query_vars already
             // (i.e. $_GET vars should not be present in the Rewrite).
-            $this->assertEquals( array(), array_intersect( $query_vars, $_qv ), 'Query vars are duplicated from the Rewrite into $_GET; ' . $ticket_ref );
+            $this->assertSame( array(), array_intersect( $query_vars, $_qv ), 'Query vars are duplicated from the Rewrite into $_GET; ' . $ticket_ref );
 
             $query_vars = array_merge( $query_vars, $_qv );