Changeset 50284 for trunk/tests/phpunit/tests/https-migration.php

Timestamp:

02/10/2021 01:24:24 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [49904], [49925], [49992], [50012], [50013], [50065], [50075], [50131], [50150], [50157].

See #38266, #52482.

File:

• trunk/tests/phpunit/tests/https-migration.php (modified) (5 diffs)

trunk/tests/phpunit/tests/https-migration.php

@@ -62 +62 @@
         // Replaces URLs, including its encoded variant.
         add_filter( 'wp_should_replace_insecure_home_url', '__return_true' );
-        $this->assertEquals( $https_content, wp_replace_insecure_home_url( $http_content ) );
+        $this->assertSame( $https_content, wp_replace_insecure_home_url( $http_content ) );
 
         // Does not replace anything if determined as unnecessary.
         add_filter( 'wp_should_replace_insecure_home_url', '__return_false' );
-        $this->assertEquals( $http_content, wp_replace_insecure_home_url( $http_content ) );
+        $this->assertSame( $http_content, wp_replace_insecure_home_url( $http_content ) );
     }
 
@@ -87 +87 @@
         // Update URLs to HTTPS (successfully).
         $this->assertTrue( wp_update_urls_to_https() );
-        $this->assertEquals( $https_url, get_option( 'home' ) );
-        $this->assertEquals( $https_url, get_option( 'siteurl' ) );
+        $this->assertSame( $https_url, get_option( 'home' ) );
+        $this->assertSame( $https_url, get_option( 'siteurl' ) );
 
         // Switch options back to use HTTP URLs, but now add filter to
@@ -99 +99 @@
         // option. Therefore the change is expected to be reverted.
         $this->assertFalse( wp_update_urls_to_https() );
-        $this->assertEquals( $http_url, get_option( 'home' ) );
-        $this->assertEquals( $http_url, get_option( 'siteurl' ) );
+        $this->assertSame( $http_url, get_option( 'home' ) );
+        $this->assertSame( $http_url, get_option( 'siteurl' ) );
     }
 
@@ -110 +110 @@
         update_option( 'fresh_site', '0' );
         wp_update_https_migration_required( 'http://example.org', 'https://example.org' );
-        $this->assertEquals( '1', get_option( 'https_migration_required' ) );
+        $this->assertTrue( get_option( 'https_migration_required' ) );
 
         // Changing another part than the scheme should delete/reset the flag because changing those parts (e.g. the
@@ -120 +120 @@
         update_option( 'fresh_site', '1' );
         wp_update_https_migration_required( 'http://example.org', 'https://example.org' );
-        $this->assertEquals( '', get_option( 'https_migration_required' ) );
+        $this->assertFalse( get_option( 'https_migration_required' ) );
 
         // Changing (back) from HTTPS to HTTP should delete/reset the flag.