Changeset 50285

Timestamp:

02/10/2021 04:52:13 PM (4 years ago)

Author:

desrosj

Message:

Build/Test Tools: Install WordPress Importer plugin when installing the Docker-based local environment.

The WordPress Importer plugin is now downloaded to the tests/phpunit/data/plugins directory when running npm run env:install.

This ensures that the PHPUnit test suite will not fail when the plugin is missing.

This also introduces a new WP_IMPORTER_REVISION variable to the .env file, to control the SVN revision that is checked out.

Props johnbillion.
Fixes #49720.

Location:

trunk

Files:

• .env (modified) (3 diffs)
• .github/workflows/phpunit-tests.yml (modified) (2 diffs)
• tools/local-env/scripts/install.js (modified) (2 diffs)

trunk/.env

@@ -46 +46 @@
 LOCAL_PHP_MEMCACHED=false
 
+##
 # The database software to use.
 #
 # Supported values are `mysql` and `mariadb`.
+##
 LOCAL_DB_TYPE=mysql
 
+##
 # The database version to use.
 #
@@ -57 +60 @@
 # When using `mysql`, see https://hub.docker.com/_/mysql/ for valid versions.
 # When using `mariadb`, see https://hub.docker.com/_/mariadb for valid versions.
+##
 LOCAL_DB_VERSION=5.7
 
@@ -68 +72 @@
 # The URL to use when running e2e tests.
 WP_BASE_URL=http://localhost:${LOCAL_PORT}
+
+##
+# The revision number of the WordPress Importer plugin to use when running unit tests.
+#
+# This should be an SVN revision number from the official plugin repository on wordpress.org.
+##
+WP_IMPORTER_REVISION=2387243

trunk/.github/workflows/phpunit-tests.yml

@@ -25 +25 @@
   # - Cancels all previous workflow runs for pull requests that have not completed.
   # - Checks out the repository.
-  # - Checks out the WordPress Importer plugin (needed for the Core PHPUnit tests).
   # - Logs debug information about the runner container.
   # - Installs NodeJS 14.
@@ -47 +46 @@
       - name: Checkout repository
         uses: actions/checkout@v2
-
-      - name: Checkout the WordPress Importer plugin
-        run: svn checkout -r 2387243 https://plugins.svn.wordpress.org/wordpress-importer/trunk/ tests/phpunit/data/plugins/wordpress-importer
 
       - name: Log debug information

trunk/tools/local-env/scripts/install.js

@@ -20 +20 @@
 // Move wp-config.php to the base directory, so it doesn't get mixed up in the src or build directories.
 renameSync( 'src/wp-config.php', 'wp-config.php' );
+
+install_wp_importer();
 
 // Read in wp-tests-config-sample.php, edit it to work with our config, then write it to wp-tests-config.php.
@@ -46 +48 @@
     execSync( `docker-compose run --rm cli ${cmd}`, { stdio: 'inherit' } );
 }
+
+/**
+ * Downloads the WordPress Importer plugin for use in tests.
+ */
+function install_wp_importer() {
+    const test_plugin_directory = 'tests/phpunit/data/plugins/wordpress-importer';
+
+    execSync( `docker-compose exec -T php rm -rf ${test_plugin_directory} && svn checkout -r ${process.env.WP_IMPORTER_REVISION} https://plugins.svn.wordpress.org/wordpress-importer/trunk/ ${test_plugin_directory}`, { stdio: 'inherit' } );
+}