Changeset 50303 for branches/5.4/.github/workflows/coding-standards.yml

Timestamp:

02/12/2021 06:00:09 PM (4 years ago)

Author:

desrosj

Message:

Build/Test Tools: Restore automated testing in the 5.4 branch.

This commit merges the workflow files required to run automated testing on GitHub Actions.

In addition, [49836] and [50285] have been included in order to keep the local Docker environment consistent across all branches.

Merges [49162,49168-49169,49175,49204,49227-49228,49244,49369,49371,49548,49781-49784,49786,49836,49938,50268,50285,50298] to the 5.4 branch.
See #50401.

Location:

branches/5.4

Files:

• . (modified) (1 prop)
• .github/workflows (copied) (copied from trunk/.github/workflows)
• .github/workflows/coding-standards.yml (modified) (7 diffs)

branches/5.4/.github/workflows/coding-standards.yml

@@ -5 +5 @@
     branches:
       - master
+      # JSHint was introduced in WordPress 3.8.
       # PHPCS checking was introduced in WordPress 5.1.
-      - '5.[1-9]'
-      - '[6-9].*'
+      - '3.[89]'
+      - '[4-9].[0-9]'
+    tags:
+      - '3.[89]*'
+      - '[4-9].[0-9]*'
   pull_request:
 
@@ -17 +21 @@
   # Performs the following steps:
   # - Checks out the repository.
-  # - Configures caching for Composer.
   # - Sets up PHP.
   # - Logs debug information.
-  # - Installs Composer dependencies (from cache if possible).
+  # - Installs Composer dependencies (use cache if possible).
+  # - Make Composer packages available globally.
   # - Logs PHP_CodeSniffer debug information.
   # - Runs PHPCS on the full codebase with warnings suppressed.
@@ -28 +32 @@
     name: PHP coding standards
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v2
 
-      - name: Get Composer cache directory
-        id: composer-cache
-        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
-
-      - name: Set up Composer caching
-        uses: actions/cache@v2
-        env:
-          cache-name: cache-composer-dependencies
-        with:
-          path: ${{ steps.composer-cache.outputs.dir }}
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-composer-
-
       - name: Set up PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '7.4'
+          php-version: '7.3'
           coverage: none
           tools: composer, cs2pr
@@ -59 +51 @@
 
       - name: Install Composer dependencies
-        run: |
-          composer install --prefer-dist --no-suggest --no-progress --no-ansi --no-interaction
-          echo "vendor/bin" >> $GITHUB_PATH
+        uses: ramsey/composer-install@v1
+        with:
+          composer-options: "--no-progress --no-ansi --no-interaction"
+
+      - name: Make Composer packages available globally
+        run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
 
       - name: Log PHPCS debug information
         run: phpcs -i
 
+      - name: Run PHPCBF on all Core files
+        run: phpcbf
+
       - name: Run PHPCS on all Core files
-        run: vendor/bin/phpcs -q -n --report=checkstyle | cs2pr
+        run: phpcs -q -n --report=checkstyle | cs2pr
 
       - name: Check test suite files for warnings
-        run: vendor/bin/phpcs tests -q --report=checkstyle | cs2pr
+        run: phpcs tests -q --report=checkstyle | cs2pr
 
   # Runs the JavaScript coding standards checks.
+  #
+  # JSHint violations are not currently reported inline with annotations.
   #
   # Performs the following steps:
   # - Checks out the repository.
   # - Logs debug information about the runner container.
-  # - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
+  # - Installs NodeJS 14.
   # - Sets up caching for NPM.
   # - Logs updated debug information.
-  # _ Installs NPM dependencies.
+  # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
   # - Run the WordPress JSHint checks.
   # - todo: Configure Slack notifications for failing tests.
@@ -86 +86 @@
     name: JavaScript coding standards
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+    env:
+      PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+
     steps:
       - name: Checkout repository
@@ -100 +104 @@
         uses: actions/setup-node@v1
         with:
-          node-version: 12
+          node-version: 14
 
       - name: Cache NodeJS modules
@@ -119 +123 @@
 
       - name: Install Dependencies
-        run: npm ci
+        run: npx install-changed --install-command="npm ci"
 
       - name: Run JSHint