Changeset 50366

Timestamp:

02/16/2021 08:22:36 PM (4 years ago)

Author:

desrosj

Message:

Editor: Correct the check for unsaved content in wp.autosave.server.postChanged().

This fixes improper triggering of the "Are you sure?" prompt when navigating away from the old, "classic" Edit Post screen and there are no changes.

The previous check did not account for Pages or any custom post types that don't have a Title, Content, or Excerpt field.

Follow-up to [50031].

Props hwk-fr, mukesh27, audrasjb, archon810, Clorith, ibiza69, tonysandwich, roger995, bartosz777, viablethought, dbtedg, worldedu, hmabpera, magnuswebdesign.
Merges [50232] to the 5.6 branch.
Fixes #52440.

Location:

branches/5.6

Files:

• . (modified) (1 prop)
• src/js/_enqueues/wp/autosave.js (modified) (2 diffs)

branches/5.6/src/js/_enqueues/wp/autosave.js

@@ -711 +711 @@
 
                         if ( ! editor || editor.isHidden() ) {
-                            if ( $( '#' + field ).val() !== initialCompareData[ field ] ) {
+                            if ( ( $( '#' + field ).val() || '' ) !== initialCompareData[ field ] ) {
                                 changed = true;
                                 // Break.
@@ -722 +722 @@
                     } );
 
-                    if ( $( '#title' ).val() !== initialCompareData.post_title ) {
+                    if ( ( $( '#title' ).val() || '' ) !== initialCompareData.post_title ) {
                         changed = true;
                     }