Changeset 50380 for trunk/src/wp-includes/post.php

Timestamp:

02/17/2021 10:56:34 PM (4 years ago)

Author:

peterwilsoncc

Message:

Posts/Post Types: Prevent duplicates in sticky posts option.

In unstick_post() if a post ID is duplicated in the sticky_posts option remove all instances.

In both stick_post() and unstick_post() check for duplicate IDs already stored in the sticky_post option and remove them if the option is updated.

Props rahmohn, archon810.
Fixes #52007.

File:

• trunk/src/wp-includes/post.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -2627 +2627 @@
     $post_id  = (int) $post_id;
     $stickies = get_option( 'sticky_posts' );
+    $updated  = false;
 
     if ( ! is_array( $stickies ) ) {
-        $stickies = array();
-    }
-
-    $stickies = array_map( 'intval', $stickies );
+        $stickies = array( $post_id );
+    } else {
+        $stickies = array_unique( array_map( 'intval', $stickies ) );
+    }
 
     if ( ! in_array( $post_id, $stickies, true ) ) {
         $stickies[] = $post_id;
-    }
-
-    $updated = update_option( 'sticky_posts', $stickies );
+        $updated    = update_option( 'sticky_posts', array_values( $stickies ) );
+    }
 
     if ( $updated ) {
@@ -2669 +2669 @@
     }
 
-    $stickies = array_map( 'intval', $stickies );
+    $stickies = array_values( array_unique( array_map( 'intval', $stickies ) ) );
 
     if ( ! in_array( $post_id, $stickies, true ) ) {