Changeset 50388

Timestamp:

02/18/2021 08:44:24 PM (4 years ago)

Author:

ryelle

Message:

Twenty Twenty-One: Add the px unit to the admin bar height custom property.

The admin bar height custom property is used in calc functions, which require consistent unit use, even when the value is zero. A unitless value returns an invalid value for the "height" property, where this variable is used. This also changes the stylelint rule in the theme to allow zero values with a unit, just in custom properties.

Props nico23.
Fixes #52564.

Location:

trunk/src/wp-content/themes/twentytwentyone

Files:

• .stylelintrc-css.json (modified) (1 diff)
• assets/css/style-editor.css (modified) (1 diff)
• assets/sass/01-settings/global.scss (modified) (1 diff)
• style-rtl.css (modified) (1 diff)
• style.css (modified) (1 diff)

trunk/src/wp-content/themes/twentytwentyone/.stylelintrc-css.json

@@ -18 +18 @@
         "selector-pseudo-element-colon-notation": null,
         "number-leading-zero": null,
-        "no-descending-specificity": null
+        "no-descending-specificity": null,
+        "length-zero-no-unit": [true, {"ignore": ["custom-properties"]}]
     }
 }

trunk/src/wp-content/themes/twentytwentyone/assets/css/style-editor.css

@@ -225 +225 @@
 
     /* Admin-bar height */
-    --global--admin-bar--height: 0;
+    --global--admin-bar--height: 0px;
 }
 

trunk/src/wp-content/themes/twentytwentyone/assets/sass/01-settings/global.scss

@@ -228 +228 @@
 
     /* Admin-bar height */
-    --global--admin-bar--height: 0;
+    --global--admin-bar--height: 0px;
 }
 

trunk/src/wp-content/themes/twentytwentyone/style-rtl.css

@@ -318 +318 @@
 
     /* Admin-bar height */
-    --global--admin-bar--height: 0;
+    --global--admin-bar--height: 0px;
 }
 

trunk/src/wp-content/themes/twentytwentyone/style.css

@@ -318 +318 @@
 
     /* Admin-bar height */
-    --global--admin-bar--height: 0;
+    --global--admin-bar--height: 0px;
 }