Changeset 50399 for trunk/src/wp-admin/includes/class-wp-site-health.php

Timestamp:

02/22/2021 12:49:17 AM (4 years ago)

Author:

peterwilsoncc

Message:

Site Health: Update loopback test to POST to wp-cron.

Replace loopback health check URL with a POST request to wp-cron.php in the WordPress install directory. This more closely represents how WordPress uses loopback requests.

A POST request is used to cause wp-cron.php to exit prior to running any cron jobs. This allows the test to indicate success quicker and accounts for sites that set the DISABLE_WP_CRON constant to avoid running cron jobs on loopback requests.

Props clorith, peterwilsoncc, TimothyBlynJacobs.
Fixes #52547.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -2648 +2648 @@
      */
     function can_perform_loopback() {
+        $body    = array( 'site-health' => 'loopback-test' );
         $cookies = wp_unslash( $_COOKIE );
         $timeout = 10;
@@ -2661 +2662 @@
         }
 
-        $url = home_url();
-
-        $r = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout', 'sslverify' ) );
+        $url = site_url( 'wp-cron.php' );
+
+        /*
+         * A post request is used for the wp-cron.php loopback test to cause the file
+         * to finish early without triggering cron jobs. This has two benefits:
+         * - cron jobs are not triggered a second time on the site health page,
+         * - the loopback request finishes sooner providing a quicker result.
+         *
+         * Using a POST request causes the loopback to differ slightly to the standard
+         * GET request WordPress uses for wp-cron.php loopback requests but is close
+         * enough. See https://core.trac.wordpress.org/ticket/52547
+         */
+        $r = wp_remote_post( $url, compact( 'body', 'cookies', 'headers', 'timeout', 'sslverify' ) );
 
         if ( is_wp_error( $r ) ) {