Changeset 50401

Timestamp:

02/22/2021 01:21:26 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Embeds: Allow posts with a public custom post status to be embedded.

Previously, only posts with the publish status could be embedded.

Props goaroundagain, peterwilsoncc, poena.
Fixes #47574.

Location:

trunk

Files:

• src/wp-includes/embed.php (modified) (2 diffs)
• tests/phpunit/tests/oembed/getResponseData.php (modified) (2 diffs)

trunk/src/wp-includes/embed.php

@@ -510 +510 @@
  * @param WP_Post|int $post  Post object or ID.
  * @param int         $width The requested width.
- * @return array|false Response data on success, false if post doesn't exist.
+ * @return array|false Response data on success, false if post doesn't exist
+ *                     or is not publicly viewable.
  */
 function get_oembed_response_data( $post, $width ) {
@@ -520 +521 @@
     }
 
-    if ( 'publish' !== get_post_status( $post ) ) {
+    if ( ! is_post_publicly_viewable( $post ) ) {
         return false;
     }

trunk/tests/phpunit/tests/oembed/getResponseData.php

@@ -3 +3 @@
 /**
  * @group oembed
+ * @covers ::get_oembed_response_data
  */
 class Tests_oEmbed_Response_Data extends WP_UnitTestCase {
@@ -129 +130 @@
     }
 
+    /**
+     * @ticket 47574
+     */
+    function test_get_oembed_response_data_with_public_true_custom_post_status() {
+        // Custom status with 'public' => true.
+        register_post_status( 'public', array( 'public' => true ) );
+
+        $post = self::factory()->post->create_and_get(
+            array(
+                'post_status' => 'public',
+            )
+        );
+
+        $this->assertNotFalse( get_oembed_response_data( $post, 100 ) );
+    }
+
+    /**
+     * @ticket 47574
+     */
+    function test_get_oembed_response_data_with_public_false_custom_post_status() {
+        // Custom status with 'public' => false.
+        register_post_status( 'private_foo', array( 'public' => false ) );
+
+        $post = self::factory()->post->create_and_get(
+            array(
+                'post_status' => 'private_foo',
+            )
+        );
+
+        $this->assertFalse( get_oembed_response_data( $post, 100 ) );
+    }
+
+    /**
+     * @ticket 47574
+     */
+    function test_get_oembed_response_data_with_unregistered_custom_post_status() {
+        $post = self::factory()->post->create_and_get(
+            array(
+                'post_status' => 'unknown_foo',
+            )
+        );
+
+        $this->assertFalse( get_oembed_response_data( $post, 100 ) );
+    }
+
     function test_get_oembed_response_data_maxwidth_too_high() {
         $post = self::factory()->post->create_and_get();