Changeset 50406

Timestamp:

02/22/2021 06:53:11 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Media: Explicitly declare the $pagenow global in wp_get_attachment_url().

This avoids an "Undefined index" PHP notice in the function when running the media test group separately.

Follow-up to [32342], [50156], [50164], [50393].

Props johnbillion.
Fixes #52606.

File:

• trunk/src/wp-includes/post.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -6278 +6278 @@
  */
 function wp_get_attachment_url( $attachment_id = 0 ) {
+    global $pagenow;
+
     $attachment_id = (int) $attachment_id;
 
@@ -6320 +6322 @@
 
     // On SSL front end, URLs should be HTTPS.
-    if ( is_ssl() && ! is_admin() && 'wp-login.php' !== $GLOBALS['pagenow'] ) {
+    if ( is_ssl() && ! is_admin() && 'wp-login.php' !== $pagenow ) {
         $url = set_url_scheme( $url );
     }