Changeset 50449 for trunk/tests/phpunit/tests/query/setupPostdata.php

Timestamp:

02/27/2021 04:54:52 PM (4 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Fix and standardise calls to the setUp() and setUpBeforeClass() methods in the test suite.

The parent methods should always be called before any test-specific functionality is set up, unless there is a specific and documented reason.

See #52625

File:

• trunk/tests/phpunit/tests/query/setupPostdata.php (modified) (1 diff)

trunk/tests/phpunit/tests/query/setupPostdata.php

@@ -11 +11 @@
 
     protected $pages_global;
-
-    public function setUp() {
-        parent::setUp();
-        return;
-
-        foreach ( $this->global_keys as $global_key ) {
-            if ( isset( $GLOBALS[ $global_key ] ) ) {
-                $this->global_data[ $global_key ] = $GLOBALS[ $global_key ];
-                unset( $GLOBALS[ $global_key ] );
-            } else {
-                $this->global_data[ $global_key ] = null;
-            }
-        }
-    }
 
     public function test_id() {