Changeset 50536

Timestamp:

03/15/2021 07:55:49 PM (3 years ago)

Author:

ryelle

Message:

Help/About: Run image comparison script after all assets have loaded.

If the callback is called before the images are loaded, the comparison doesn't work. wp.domReady uses DOMContentLoaded, which does not guarantee that the images are loaded. This switches to use the load event, which waits for all resources to load.

Props vladytimy, joyously, sergeybiryukov.
Merges [50535] to the 5.7 branch.
Fixes #52758.

Location:

branches/5.7

Files:

• . (modified) (1 prop)
• src/wp-admin/about.php (modified) (1 diff)

branches/5.7/src/wp-admin/about.php

@@ -240 +240 @@
 
 <script>
-    wp.domReady( function() {
+    window.addEventListener( 'load', function() {
         var createElement = wp.element.createElement;
         var Fragment = wp.element.Fragment;