Changeset 50540

Timestamp:

03/18/2021 12:42:28 PM (4 years ago)

Author:

desrosj

Message:

Build/Test Tools: Remove explicit puppeteer dependency.

This was added in [48177] to fix an issue where Puppeteer was not being installed correctly as a dependency of @wordpress/wp-scripts. This has been fixed, so this explicit dependency can be removed.

Props isabel_brison.
Fixes #52843.

Location:

trunk

Files:

• package-lock.json (modified) (4 diffs)
• package.json (modified) (1 diff)
• tests/e2e/run-tests.js (modified) (2 diffs)

trunk/package-lock.json

@@ -2316 +2316 @@
             }
         },
-        "@types/mime-types": {
-            "version": "2.1.0",
-            "resolved": "https://registry.npmjs.org/@types/mime-types/-/mime-types-2.1.0.tgz",
-            "integrity": "sha1-nKUs2jY/aZxpRmwqbM2q2RPqenM=",
-            "dev": true
-        },
         "@types/minimatch": {
             "version": "3.0.3",
@@ -3931 +3925 @@
                         "unbzip2-stream": "^1.3.3",
                         "ws": "^7.2.3"
-                    },
-                    "dependencies": {
-                        "devtools-protocol": {
-                            "version": "0.0.818844",
-                            "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.818844.tgz",
-                            "integrity": "sha512-AD1hi7iVJ8OD0aMLQU5VK0XH9LDlA1+BcPIgrAxPfaibx2DbWucuyOhc4oyQCbnvDDO68nN6/LcKfqTP343Jjg==",
-                            "dev": true
-                        }
                     }
                 },
@@ -8064 +8050 @@
             "resolved": "https://registry.npmjs.org/detect-node/-/detect-node-2.0.4.tgz",
             "integrity": "sha512-ZIzRpLJrOj7jjP2miAtgqIfmzbxa4ZOr5jJc601zklsfEx9oTzmmj2nVpIPRpNlRTIh8lc1kyViIY7BWSGNmKw==",
+            "dev": true
+        },
+        "devtools-protocol": {
+            "version": "0.0.818844",
+            "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.818844.tgz",
+            "integrity": "sha512-AD1hi7iVJ8OD0aMLQU5VK0XH9LDlA1+BcPIgrAxPfaibx2DbWucuyOhc4oyQCbnvDDO68nN6/LcKfqTP343Jjg==",
             "dev": true
         },
@@ -18643 +18635 @@
             "resolved": "https://registry.npmjs.org/punycode/-/punycode-2.1.1.tgz",
             "integrity": "sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A=="
-        },
-        "puppeteer": {
-            "version": "npm:puppeteer-core@3.0.0",
-            "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-3.0.0.tgz",
-            "integrity": "sha512-oWjZFGMc0q2ak+8OxdmMffS79LIT0UEtmpV4h1/AARvESIqqKljf8mrfP+dQ2kas7XttsAZIxRBuWu7Y5JH8KQ==",
-            "dev": true,
-            "requires": {
-                "@types/mime-types": "^2.1.0",
-                "debug": "^4.1.0",
-                "extract-zip": "^2.0.0",
-                "https-proxy-agent": "^4.0.0",
-                "mime": "^2.0.3",
-                "mime-types": "^2.1.25",
-                "progress": "^2.0.1",
-                "proxy-from-env": "^1.0.0",
-                "rimraf": "^3.0.2",
-                "tar-fs": "^2.0.0",
-                "unbzip2-stream": "^1.3.3",
-                "ws": "^7.2.3"
-            },
-            "dependencies": {
-                "rimraf": {
-                    "version": "3.0.2",
-                    "resolved": "https://registry.npmjs.org/rimraf/-/rimraf-3.0.2.tgz",
-                    "integrity": "sha512-JZkJMZkAGFFPP2YqXZXPbMlMBgsxzE8ILs4lMIX/2o0L9UBw9O/Y3o6wFw/i9YLapcUJWwqbi3kdxIPdC62TIA==",
-                    "dev": true,
-                    "requires": {
-                        "glob": "^7.1.3"
-                    }
-                }
-            }
         },
         "q": {

trunk/package.json

@@ -64 +64 @@
         "matchdep": "~2.0.0",
         "prettier": "npm:wp-prettier@2.0.5",
-        "puppeteer": "npm:puppeteer-core@3.0.0",
         "qunit": "~2.14.0",
         "sass": "^1.32.8",

trunk/tests/e2e/run-tests.js

@@ -1 +1 @@
 const dotenv = require( 'dotenv' );
 const dotenv_expand = require( 'dotenv-expand' );
-const { sync: spawn } = require( 'cross-spawn' );
 const { execSync } = require( 'child_process' );
 
@@ -7 +6 @@
 dotenv_expand( dotenv.config() );
 
-const result = spawn( 'node', [ require.resolve( 'puppeteer/install' ) ], {
-    stdio: 'inherit',
-} );
-if ( result.status > 0 ) {
-    process.exit( result.status );
-}
-
 // Run the tests, passing additional arguments through to the test script.
-execSync( 'wp-scripts test-e2e --config tests/e2e/jest.config.js ' + process.argv.slice( 2 ).join( ' ' ), { stdio: 'inherit' } );
+execSync(
+    'wp-scripts test-e2e --config tests/e2e/jest.config.js ' +
+        process.argv.slice( 2 ).join( ' ' ),
+    { stdio: 'inherit' }
+);