Changeset 50552 for trunk

Timestamp:

03/18/2021 11:59:12 PM (4 years ago)

Author:

whyisjake

Message:

Media: Pass the appropriate reference into wp_getimagesize.

With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.

Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.

This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.

For more see:

• ​https://github.com/humanmade/S3-Uploads/issues/496
• ​https://github.com/aws/aws-sdk-php/issues/1923

Fixes #52826.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.

Location:

trunk/src

Files:

• wp-admin/includes/image.php (modified) (1 diff)
• wp-includes/media.php (modified) (3 diffs)

trunk/src/wp-admin/includes/image.php

@@ -712 +712 @@
 
     $iptc = array();
+    $info = array();
     /*
      * Read IPTC first, since it might contain data not available in exif such

trunk/src/wp-includes/media.php

@@ -4976 +4976 @@
  * @since 5.7.0
  *
- * @param string $filename  The file path.
- * @param array  $imageinfo Extended image information, passed by reference.
+ * @param string $filename   The file path.
+ * @param array  $image_info Optional. Extended image information (passed by reference).
  * @return array|false Array of image information or false on failure.
  */
-function wp_getimagesize( $filename, &$imageinfo = array() ) {
+function wp_getimagesize( $filename, array &$image_info = null ) {
     if (
         // Skip when running unit tests.
@@ -4988 +4988 @@
         defined( 'WP_DEBUG' ) && WP_DEBUG
     ) {
-        return getimagesize( $filename, $imageinfo );
+        return getimagesize( $filename, $image_info );
     }
 
@@ -5002 +5002 @@
      * phpcs:ignore WordPress.PHP.NoSilencedErrors
      */
-    return @getimagesize( $filename, $imageinfo );
-}
+    return @getimagesize( $filename, $image_info );
+}