Changeset 50552 for trunk/src/wp-admin/includes/image.php

Timestamp:

03/18/2021 11:59:12 PM (5 years ago)

Author:

whyisjake

Message:

Media: Pass the appropriate reference into wp_getimagesize.

With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.

Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.

This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.

For more see:

• ​https://github.com/humanmade/S3-Uploads/issues/496
• ​https://github.com/aws/aws-sdk-php/issues/1923

Fixes #52826.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.

File:

• trunk/src/wp-admin/includes/image.php (modified) (1 diff)

trunk/src/wp-admin/includes/image.php

@@ -712 +712 @@
 
     $iptc = array();
+    $info = array();
     /*
      * Read IPTC first, since it might contain data not available in exif such