Changeset 50558

Timestamp:

03/21/2021 12:39:25 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison for return type checks in a few functions:

• get_bookmark()
• get_comment()
• get_post()
• get_children()
• wp_get_recent_posts()
• wp_get_post_revision()
• wp_get_nav_menu_items()

Follow-up to [45710] for get_term(), [48507] for wpdb::get_row() and wpdb::get_results().

See #52627.

Location:

trunk/src/wp-includes

Files:

• bookmark.php (modified) (1 diff)
• comment.php (modified) (1 diff)
• nav-menu.php (modified) (2 diffs)
• post.php (modified) (4 diffs)
• revision.php (modified) (1 diff)

trunk/src/wp-includes/bookmark.php

@@ -54 +54 @@
     $_bookmark = sanitize_bookmark( $_bookmark, $filter );
 
-    if ( OBJECT == $output ) {
+    if ( OBJECT === $output ) {
         return $_bookmark;
-    } elseif ( ARRAY_A == $output ) {
+    } elseif ( ARRAY_A === $output ) {
         return get_object_vars( $_bookmark );
-    } elseif ( ARRAY_N == $output ) {
+    } elseif ( ARRAY_N === $output ) {
         return array_values( get_object_vars( $_bookmark ) );
     } else {

trunk/src/wp-includes/comment.php

@@ -219 +219 @@
     $_comment = apply_filters( 'get_comment', $_comment );
 
-    if ( OBJECT == $output ) {
+    if ( OBJECT === $output ) {
         return $_comment;
-    } elseif ( ARRAY_A == $output ) {
+    } elseif ( ARRAY_A === $output ) {
         return $_comment->to_array();
-    } elseif ( ARRAY_N == $output ) {
+    } elseif ( ARRAY_N === $output ) {
         return array_values( $_comment->to_array() );
     }

trunk/src/wp-includes/nav-menu.php

@@ -759 +759 @@
     }
 
-    if ( ARRAY_A == $args['output'] ) {
+    if ( ARRAY_A === $args['output'] ) {
         $items = wp_list_sort(
             $items,
@@ -766 +766 @@
             )
         );
-        $i     = 1;
+
+        $i = 1;
+
         foreach ( $items as $k => $item ) {
             $items[ $k ]->{$args['output_key']} = $i++;

trunk/src/wp-includes/post.php

@@ -678 +678 @@
     }
 
-    if ( OBJECT == $output ) {
+    if ( OBJECT === $output ) {
         return $kids;
-    } elseif ( ARRAY_A == $output ) {
+    } elseif ( ARRAY_A === $output ) {
         $weeuns = array();
         foreach ( (array) $kids as $kid ) {
@@ -686 +686 @@
         }
         return $weeuns;
-    } elseif ( ARRAY_N == $output ) {
+    } elseif ( ARRAY_N === $output ) {
         $babes = array();
         foreach ( (array) $kids as $kid ) {
@@ -789 +789 @@
     $_post = $_post->filter( $filter );
 
-    if ( ARRAY_A == $output ) {
+    if ( ARRAY_A === $output ) {
         return $_post->to_array();
-    } elseif ( ARRAY_N == $output ) {
+    } elseif ( ARRAY_N === $output ) {
         return array_values( $_post->to_array() );
     }
@@ -3693 +3693 @@
 
     // Backward compatibility. Prior to 3.1 expected posts to be returned in array.
-    if ( ARRAY_A == $output ) {
+    if ( ARRAY_A === $output ) {
         foreach ( $results as $key => $result ) {
             $results[ $key ] = get_object_vars( $result );

trunk/src/wp-includes/revision.php

@@ -372 +372 @@
     }
 
-    if ( OBJECT == $output ) {
+    if ( OBJECT === $output ) {
         return $revision;
-    } elseif ( ARRAY_A == $output ) {
+    } elseif ( ARRAY_A === $output ) {
         $_revision = get_object_vars( $revision );
         return $_revision;
-    } elseif ( ARRAY_N == $output ) {
+    } elseif ( ARRAY_N === $output ) {
         $_revision = array_values( get_object_vars( $revision ) );
         return $_revision;