Changeset 50565 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

03/23/2021 01:53:50 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Use a consistent check for the $rewrite['hierarchical'] parameter.

This avoids a "Trying to access array offset on value of type bool" PHP warning in get_term_link() if the $rewrite parameter of register_taxonomy() is set as false.

Props Tkama, SergeyBiryukov.
Fixes #52882.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-query.php

@@ -1119 +1119 @@
                 );
 
-                if ( isset( $t->rewrite['hierarchical'] ) && $t->rewrite['hierarchical'] ) {
+                if ( ! empty( $t->rewrite['hierarchical'] ) ) {
                     $q[ $t->query_var ] = wp_basename( $q[ $t->query_var ] );
                 }