Changeset 50567 for trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

Timestamp:

03/23/2021 11:34:59 PM (4 years ago)

Author:

peterwilsoncc

Message:

REST API: Prevent database error when deleting meta data.

Add a check to WP_REST_Meta_Fields::delete_meta_value() ensuring meta data is set before attempting to delete it from the database. If the data does not exist, the delete is considered successful as the data matches the desired state.

Props BrechtVds, goaroundagain, TimothyBlynJacobs.
Fixes #52787.

File:

• trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

@@ -1051 +1051 @@
         $meta = get_post_meta( self::$post_id, 'test_multi', false );
         $this->assertEmpty( $meta );
+    }
+
+    /**
+     * Ensure deleting non-existant meta data behaves gracefully.
+     *
+     * @ticket 52787
+     * @dataProvider data_delete_does_not_trigger_error_if_no_meta_values
+     *
+     * @param array|null $delete_value Value used to delete meta data.
+     */
+    public function test_delete_does_not_trigger_error_if_no_meta_values( $delete_value ) {
+        $this->grant_write_permission();
+
+        $data    = array(
+            'meta' => array(
+                'test_multi' => $delete_value,
+            ),
+        );
+        $request = new WP_REST_Request( 'POST', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+        $request->set_body_params( $data );
+
+        $response = rest_get_server()->dispatch( $request );
+
+        $this->assertSame( 200, $response->get_status() );
+    }
+
+    /**
+     * Data provider for test_delete_does_not_trigger_error_if_no_meta_values().
+     *
+     * @return array[] Array of test parameters.
+     */
+    public function data_delete_does_not_trigger_error_if_no_meta_values() {
+        return array(
+            array( array() ),
+            array( null ),
+        );
     }