Changeset 50576

Timestamp:

03/25/2021 12:37:49 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Query: Consistently include a space in parentheses in WP_Meta_Query::get_sql_for_clause().

Props jillebehm, kaavyaiyer, hareesh-pillai.
Fixes #49279.

Location:

trunk/src/wp-includes

Files:

• class-wp-meta-query.php (modified) (1 diff)
• class-wp-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-meta-query.php

@@ -561 +561 @@
 
                 if ( 'LIKE' === $meta_compare_key ) {
-                    $join .= $wpdb->prepare( " ON ($this->primary_table.$this->primary_id_column = $alias.$this->meta_id_column AND $alias.meta_key LIKE %s )", '%' . $wpdb->esc_like( $clause['key'] ) . '%' );
+                    $join .= $wpdb->prepare( " ON ( $this->primary_table.$this->primary_id_column = $alias.$this->meta_id_column AND $alias.meta_key LIKE %s )", '%' . $wpdb->esc_like( $clause['key'] ) . '%' );
                 } else {
-                    $join .= $wpdb->prepare( " ON ($this->primary_table.$this->primary_id_column = $alias.$this->meta_id_column AND $alias.meta_key = %s )", $clause['key'] );
+                    $join .= $wpdb->prepare( " ON ( $this->primary_table.$this->primary_id_column = $alias.$this->meta_id_column AND $alias.meta_key = %s )", $clause['key'] );
                 }
 

trunk/src/wp-includes/class-wp-query.php

@@ -2599 +2599 @@
         if ( $this->is_comment_feed && ! $this->is_singular ) {
             if ( $this->is_archive || $this->is_search ) {
-                $cjoin    = "JOIN {$wpdb->posts} ON ({$wpdb->comments}.comment_post_ID = {$wpdb->posts}.ID) $join ";
+                $cjoin    = "JOIN {$wpdb->posts} ON ( {$wpdb->comments}.comment_post_ID = {$wpdb->posts}.ID ) $join ";
                 $cwhere   = "WHERE comment_approved = '1' $where";
                 $cgroupby = "{$wpdb->comments}.comment_id";