Changeset 50587 for branches/5.7/src/wp-includes/robots-template.php

Timestamp:

03/26/2021 12:26:55 AM (4 years ago)

Author:

peterwilsoncc

Message:

Robots: Remove contradictory directive check in wp_robots().

Removes the mutually exclusive directives check in wp_robots(), ie allow both follow and nofollow to be specified and for archive and noarchive to be specified.

This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.

Props Cybr, flixos90, SergeyBiryukov.
Merges [50566] to the 5.7 branch.
Fixes #52713.

Location:

branches/5.7

Files:

• . (modified) (1 prop)
• src/wp-includes/robots-template.php (modified) (2 diffs)

branches/5.7/src/wp-includes/robots-template.php

@@ -16 +16 @@
  *
  * @since 5.7.0
+ * @since 5.7.1 No longer prevents specific directives to occur together.
  */
 function wp_robots() {
@@ -30 +31 @@
      */
     $robots = apply_filters( 'wp_robots', array() );
-
-    // Don't allow mutually exclusive directives.
-    if ( ! empty( $robots['follow'] ) ) {
-        unset( $robots['nofollow'] );
-    }
-    if ( ! empty( $robots['nofollow'] ) ) {
-        unset( $robots['follow'] );
-    }
-    if ( ! empty( $robots['archive'] ) ) {
-        unset( $robots['noarchive'] );
-    }
-    if ( ! empty( $robots['noarchive'] ) ) {
-        unset( $robots['archive'] );
-    }
 
     $robots_strings = array();