Changeset 50635 for branches/4.8/.github/workflows/phpunit-tests.yml

Timestamp:

04/02/2021 03:24:27 PM (3 years ago)

Author:

desrosj

Message:

Build/Test Tools: Backport GitHub Action and build improvements to the 4.8 branch.

This backports several build and test tool improvements to the 4.8 branch. Most notably, this includes:

• The changes required to allow each workflow to be triggered by the workflow_dispatch event so that tests can be run on a schedule [50590].
• Splitting single site and multisite tests into parallel jobs [50379].
• Split slow tests into separate, parallel jobs for PHP <= 5.6 [50444].
• Better branch and path scoping for GitHub Action workflows when running on pull_request [50432,50479].
• Several devDependency updates.

Merges [50379,50387,50413,50416,50432,50435,50436,50444,50446,50473,50474,50476,50479,50485,50486,50487,50545,50579,50590] to the 4.8 branch.
See #50401, #51801, #51802, #52548, #52608, #52612, #52624, #52625, #52645, #52653, #52658, #52660, #52667.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• .github/workflows/phpunit-tests.yml (modified) (15 diffs)

branches/4.8/.github/workflows/phpunit-tests.yml

@@ -5 +5 @@
     branches:
       - master
+      - trunk
       - '3.[7-9]'
       - '[4-9].[0-9]'
@@ -11 +12 @@
       - '[4-9].[0-9]*'
   pull_request:
+    branches:
+      - master
+      - trunk
+      - '3.[7-9]'
+      - '[4-9].[0-9]'
+  workflow_dispatch:
   # Once weekly On Sundays at 00:00 UTC.
   schedule:
@@ -22 +29 @@
   PHPUNIT_SCRIPT: php
   LOCAL_PHP_MEMCACHED: ${{ false }}
+  SLOW_TESTS: 'external-http,media,restapi'
 
 jobs:
@@ -44 +52 @@
       - name: Cancel previous runs of this workflow (pull requests only)
         if: ${{ github.event_name == 'pull_request' }}
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
+        uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
 
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
 
       - name: Log debug information
@@ -65 +71 @@
 
       - name: Install NodeJS
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
         with:
           node-version: 14
 
       - name: Cache NodeJS modules
-        uses: actions/cache@v2
+        uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
         env:
           cache-name: cache-node-modules
@@ -77 +83 @@
           path: ~/.npm
           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-npm-
 
       - name: Install Dependencies
-        run: npx install-changed --install-command="npm ci"
+        run: npm ci
 
       - name: Build WordPress
@@ -87 +91 @@
 
       - name: Create ZIP artifact
-        uses: thedoctor0/zip-release@0.4.1
+        uses: thedoctor0/zip-release@a1afcab9c664c9976ac398fa831eac67bed1eb0e # v0.4.1
         with:
           filename: built-wp-${{ github.sha }}.zip
@@ -93 +97 @@
 
       - name: Upload build artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2.2.2
         with:
           name: built-wp-${{ github.sha }}
@@ -125 +129 @@
   # - todo: Configure Slack notifications for failing tests.
   test-php:
-    name: ${{ matrix.php }}${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
+    name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }} ${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
     needs: setup-wordpress
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
-        php: [ '7.1' ]
-        phpunit: [ '6-php-7.1' ]
+        php: [ '5.3', '5.4', '5.5' ]
         os: [ ubuntu-latest ]
         memcached: [ false ]
+        split_slow: [ false, true ]
+        multisite: [ false, true ]
         include:
+          # Additional "slow" jobs for PHP 5.6.
+          - php: '5.6'
+            phpunit: '4-php-5.6'
+            os: ubuntu-latest
+            memcached: false
+            multisite: false
+            split_slow: true
+          - php: '5.6'
+            phpunit: '4-php-5.6'
+            os: ubuntu-latest
+            memcached: false
+            multisite: true
+            split_slow: true
+          # Include job for specific PHPUnit versions.
+          - php: '7.1'
+            phpunit: '6-php-7.1'
+            os: ubuntu-latest
+            memcached: false
+            multisite: false
+            split_slow: false
+          - php: '7.1'
+            phpunit: '6-php-7.1'
+            os: ubuntu-latest
+            memcached: false
+            multisite: true
+            split_slow: false
+          - php: '7.0'
+            phpunit: '6-php-7.0'
+            os: ubuntu-latest
+            memcached: false
+            multisite: false
+            split_slow: false
+          - php: '7.0'
+            phpunit: '6-php-7.0'
+            os: ubuntu-latest
+            memcached: false
+            multisite: true
+            split_slow: false
+          - php: '5.6'
+            phpunit: '4-php-5.6'
+            os: ubuntu-latest
+            memcached: false
+            multisite: false
+            split_slow: false
+          - php: '5.6'
+            phpunit: '4-php-5.6'
+            os: ubuntu-latest
+            memcached: false
+            multisite: true
+            split_slow: false
           # Include job for PHP 7.1 with memcached.
           - php: '7.1'
@@ -140 +196 @@
             os: ubuntu-latest
             memcached: true
-          - php: '7.0'
-            phpunit: '6-php-7.0'
-            os: ubuntu-latest
-            memcached: false
-          - php: '5.6'
-            phpunit: '4-php-5.6'
-            os: ubuntu-latest
-            memcached: false
-          - php: '5.5'
-            phpunit: '5.5'
-            os: ubuntu-latest
-            memcached: false
-          - php: '5.4'
-            phpunit: '5.4'
-            os: ubuntu-latest
-            memcached: false
-          - php: '5.3'
-            phpunit: '5.3'
-            os: ubuntu-latest
-            memcached: false
+            multisite: false
+            split_slow: false
+
     env:
       LOCAL_PHP: ${{ matrix.php }}-fpm
-      LOCAL_PHPUNIT: ${{ matrix.phpunit }}-fpm
+      LOCAL_PHPUNIT: ${{ matrix.phpunit && matrix.phpunit || matrix.php }}-fpm
       LOCAL_PHP_MEMCACHED: ${{ matrix.memcached }}
+      PHPUNIT_CONFIG: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }}
 
     steps:
@@ -172 +212 @@
 
       - name: Download the built WordPress artifact
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843 # v2.0.8
         with:
           name: built-wp-${{ github.sha }}
@@ -180 +220 @@
 
       - name: Install NodeJS
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
         with:
           node-version: 14
 
       - name: Use cached Node modules
-        uses: actions/cache@v2
+        uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
         env:
           cache-name: cache-node-modules
@@ -192 +232 @@
           path: ~/.npm
           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-npm-
 
       - name: Install Dependencies
-        run: npx install-changed --install-command="npm ci"
+        run: npm ci
 
       - name: Cache Composer dependencies
         if: ${{ env.COMPOSER_INSTALL == true }}
-        uses: actions/cache@v2
+        uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
         env:
           cache-name: cache-composer-dependencies
@@ -206 +244 @@
           path: ${{ steps.composer-cache.outputs.dir }}
           key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-php-${{ matrix.php }}-composer-
 
       - name: Install Composer dependencies
@@ -253 +289 @@
         run: npm run env:install
 
+      - name: Run slow PHPUnit tests
+        if: ${{ matrix.split_slow }}
+        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --group ${{ env.SLOW_TESTS }}
+
+      - name: Run PHPUnit tests for single site excluding slow tests
+        if: ${{ matrix.php < '7.0' && ! matrix.split_slow && ! matrix.multisite }}
+        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --exclude-group ${{ env.SLOW_TESTS }},ajax,ms-files,ms-required
+
+      - name: Run PHPUnit tests for Multisite excluding slow tests
+        if: ${{ matrix.php < '7.0' && ! matrix.split_slow && matrix.multisite }}
+        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --exclude-group ${{ env.SLOW_TESTS }},ajax,ms-files,ms-excluded,oembed-headers
+
       - name: Run PHPUnit tests
-        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c phpunit.xml.dist
+        if: ${{ matrix.php >= '7.0' }}
+        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }}
 
       - name: Run AJAX tests
-        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c phpunit.xml.dist --group ajax
-
-      - name: Run tests as a multisite install
-        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c tests/phpunit/multisite.xml
+        if: ${{ ! matrix.multisite && ! matrix.split_slow }}
+        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --group ajax
 
       - name: Run ms-files tests as a multisite install
+        if: ${{ matrix.multisite && ! matrix.split_slow }}
         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c tests/phpunit/multisite.xml --group ms-files
 
       - name: Run external HTTP tests
+        if: ${{ ! matrix.multisite && ! matrix.split_slow }}
         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c phpunit.xml.dist --group external-http
-
-      - name: Run REST API tests
-        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c phpunit.xml.dist --group restapi-jsclient
 
       - name: Checkout the WordPress Test Reporter
         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
         with:
           repository: 'WordPress/phpunit-test-runner'