Changeset 50660 for branches/5.7

Timestamp:

04/06/2021 03:38:56 AM (4 years ago)

Author:

peterwilsoncc

Message:

Site Health: Reduce false reports of HTTPS failures.

Reduce severity of failing HTTPS tests from critical to warning. Stop reporting failures if the site is being accessed over HTTPS but wp_is_https_supported() indicates a lack of support.

Props annalamprou, AnotherDave, ayeshrajans, bobbingwide, Clorith, dragongate, eatsleepcode, gab81, geoffrey1963, Ipstenu, k3nsai, mmuyskens, nicegamer7, peterwilsoncc, pwallner, SergeyBiryukov, TimothyBlynJacobs, Toru.
Merges [50659] to the 5.7 branch.
Fixes #52783.

Location:

branches/5.7

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-site-health.php (modified) (2 diffs)

branches/5.7/src/wp-admin/includes/class-wp-site-health.php

@@ -1529 +1529 @@
             // If the website is not using HTTPS, provide more information about whether it is supported and how it can
             // be enabled.
-            $result['status'] = 'critical';
+            $result['status'] = 'warning';
             $result['label']  = __( 'Your website does not use HTTPS' );
 
@@ -1631 +1631 @@
                 }
             }
-        } elseif ( ! wp_is_https_supported() ) {
-            // If the website is using HTTPS, but HTTPS is actually not supported, inform the user about the potential
-            // problems.
-            $result['status'] = 'critical';
-            $result['label']  = __( 'There are problems with the HTTPS connection of your website' );
-
-            $https_detection_errors = get_option( 'https_detection_errors' );
-            if ( ! empty( $https_detection_errors['ssl_verification_failed'] ) ) {
-                $result['description'] = sprintf(
-                    '<p>%s</p>',
-                    sprintf(
-                        /* translators: %s: URL to Settings > General > WordPress Address. */
-                        __( 'Your <a href="%s">WordPress Address</a> is set up to use HTTPS, but the SSL certificate appears to be invalid.' ),
-                        esc_url( admin_url( 'options-general.php' ) . '#siteurl' )
-                    )
-                );
-            } else {
-                $result['description'] = sprintf(
-                    '<p>%s</p>',
-                    sprintf(
-                        /* translators: %s: URL to Settings > General > WordPress Address. */
-                        __( 'Your <a href="%s">WordPress Address</a> is set up to use HTTPS, but your website appears to be unavailable when using an HTTPS connection.' ),
-                        esc_url( admin_url( 'options-general.php' ) . '#siteurl' )
-                    )
-                );
-            }
-            $result['description'] .= sprintf(
-                '<p>%s</p>',
-                __( 'Talk to your web host about resolving this HTTPS issue for your website.' )
-            );
         }