Changeset 50684 for branches/5.7/tests/phpunit/tests/media.php

Timestamp:

04/07/2021 01:50:59 AM (7 months ago)

Author:

peterwilsoncc

Message:

Media: Do not lazy load hidden images or embeds.

Improve the check for sourceless or dimensionless media when determining if the lazy loading attribute should be added to iframes and images. Never include the lazy loading attribute on embeds of WordPress posts as the iframe is initially hidden.

Including loading="lazy" on initially hidden iframes and images can prevent the media from loading in some browsers.

Props adamsilverstein, fabianpimminger, flixos90, johnbillion, jonkastonka, joyously, peterwilsoncc, SergeyBiryukov, SirStuey, swissspidy.
Merges [50682], [50683] to the 5.7 branch.
Fixes #52768.

Location:

branches/5.7

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/media.php (modified) (1 diff)

branches/5.7/tests/phpunit/tests/media.php

@@ -2936 +2936 @@
         $iframe = '<iframe src="https://www.example.com" width="640" height="360"></iframe>';
         add_filter( 'wp_iframe_tag_add_loading_attr', '__return_false' );
+        $iframe = wp_iframe_tag_add_loading_attr( $iframe, 'test' );
+
+        $this->assertNotContains( ' loading=', $iframe );
+    }
+
+    /**
+     * @ticket 52768
+     */
+    function test_wp_iframe_tag_add_loading_attr_skip_wp_embed() {
+        $iframe   = '<iframe src="https://www.example.com" width="640" height="360"></iframe>';
+        $fallback = '<blockquote>Fallback content.</blockquote>';
+        $iframe   = wp_filter_oembed_result( $fallback . $iframe, (object) array( 'type' => 'rich' ), 'https://www.example.com' );
+        $iframe   = wp_iframe_tag_add_loading_attr( $iframe, 'test' );
 
         $this->assertNotContains( ' loading=', $iframe );