WordPress.org

Make WordPress Core


Ignore:
Timestamp:
04/07/2021 01:50:59 AM (2 weeks ago)
Author:
peterwilsoncc
Message:

Media: Do not lazy load hidden images or embeds.

Improve the check for sourceless or dimensionless media when determining if the lazy loading attribute should be added to iframes and images. Never include the lazy loading attribute on embeds of WordPress posts as the iframe is initially hidden.

Including loading="lazy" on initially hidden iframes and images can prevent the media from loading in some browsers.

Props adamsilverstein, fabianpimminger, flixos90, johnbillion, jonkastonka, joyously, peterwilsoncc, SergeyBiryukov, SirStuey, swissspidy.
Merges [50682], [50683] to the 5.7 branch.
Fixes #52768.

Location:
branches/5.7
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/5.7

  • branches/5.7/tests/phpunit/tests/media.php

    r50132 r50684  
    29362936        $iframe = '<iframe src="https://www.example.com" width="640" height="360"></iframe>';
    29372937        add_filter( 'wp_iframe_tag_add_loading_attr', '__return_false' );
     2938        $iframe = wp_iframe_tag_add_loading_attr( $iframe, 'test' );
     2939
     2940        $this->assertNotContains( ' loading=', $iframe );
     2941    }
     2942
     2943    /**
     2944     * @ticket 52768
     2945     */
     2946    function test_wp_iframe_tag_add_loading_attr_skip_wp_embed() {
     2947        $iframe   = '<iframe src="https://www.example.com" width="640" height="360"></iframe>';
     2948        $fallback = '<blockquote>Fallback content.</blockquote>';
     2949        $iframe   = wp_filter_oembed_result( $fallback . $iframe, (object) array( 'type' => 'rich' ), 'https://www.example.com' );
     2950        $iframe   = wp_iframe_tag_add_loading_attr( $iframe, 'test' );
    29382951
    29392952        $this->assertNotContains( ' loading=', $iframe );
Note: See TracChangeset for help on using the changeset viewer.